From 7f98eab4817ad6a7e869a620685bdd248c964129 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Mon, 26 Sep 2016 14:55:16 -0300 Subject: [PATCH] Bug 17327: (QA followup) Remove Carp::Always which is not used This patch removes the need for Carp::Always in .../Reserves/MultiplePerRecord.t which is not actually used. It also removes 'undef' from Koha::Holds::forced_hold_level's last return, to comply with our QA rules. Signed-off-by: Tomas Cohen Arazi --- Koha/Holds.pm | 2 +- t/db_dependent/Reserves/MultiplePerRecord.t | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/Koha/Holds.pm b/Koha/Holds.pm index 6dc0c9e..038e31c 100644 --- a/Koha/Holds.pm +++ b/Koha/Holds.pm @@ -77,7 +77,7 @@ sub forced_hold_level { my $record_level_count = $self->search( { itemnumber => undef } )->count(); return 'record' if $record_level_count > 0; - return undef; + return; } =head3 type diff --git a/t/db_dependent/Reserves/MultiplePerRecord.t b/t/db_dependent/Reserves/MultiplePerRecord.t index 9771051..d2da653 100755 --- a/t/db_dependent/Reserves/MultiplePerRecord.t +++ b/t/db_dependent/Reserves/MultiplePerRecord.t @@ -17,7 +17,6 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use Carp::Always; use Modern::Perl; use Test::More tests => 38; -- 2.7.4