View | Details | Raw Unified | Return to bug 15131
Collapse All | Expand All

(-)a/C4/UsageStats.pm (+1 lines)
Lines 121-126 sub BuildReport { Link Here
121
        AllFinesNeedOverride
121
        AllFinesNeedOverride
122
        AllowFineOverride
122
        AllowFineOverride
123
        AllowItemsOnHoldCheckout
123
        AllowItemsOnHoldCheckout
124
        AllowItemsOnHoldCheckoutSCO
124
        AllowNotForLoanOverride
125
        AllowNotForLoanOverride
125
        AllowRenewalLimitOverride
126
        AllowRenewalLimitOverride
126
        AllowReturnToBranch
127
        AllowReturnToBranch
(-)a/t/db_dependent/UsageStats.t (-3 / +13 lines)
Lines 15-23 Link Here
15
# with Koha; if not, see <http://www.gnu.org/licenses>.
15
# with Koha; if not, see <http://www.gnu.org/licenses>.
16
16
17
use Modern::Perl;
17
use Modern::Perl;
18
use Test::More tests => 545;
18
use Test::More tests => 57;
19
use t::lib::Mocks qw(mock_preference);
19
use t::lib::Mocks qw(mock_preference);
20
use POSIX qw(strftime);
20
use POSIX qw(strftime);
21
use Data::Dumper;
21
22
22
BEGIN {
23
BEGIN {
23
    use_ok('C4::UsageStats');
24
    use_ok('C4::UsageStats');
Lines 372-377 sub mocking_systempreferences_to_a_set_value { Link Here
372
        AllFinesNeedOverride
373
        AllFinesNeedOverride
373
        AllowFineOverride
374
        AllowFineOverride
374
        AllowItemsOnHoldCheckout
375
        AllowItemsOnHoldCheckout
376
        AllowItemsOnHoldCheckoutSCO
375
        AllowNotForLoanOverride
377
        AllowNotForLoanOverride
376
        AllowRenewalLimitOverride
378
        AllowRenewalLimitOverride
377
        AllowReturnToBranch
379
        AllowReturnToBranch
Lines 586-593 sub mocking_systempreferences_to_a_set_value { Link Here
586
sub verif_systempreferences_values {
588
sub verif_systempreferences_values {
587
    my ( $report, $value_to_test ) = @_;
589
    my ( $report, $value_to_test ) = @_;
588
590
591
    my @missings;
589
    foreach my $key ( keys %{$report->{systempreferences}} ) {
592
    foreach my $key ( keys %{$report->{systempreferences}} ) {
590
        is( $report->{systempreferences}->{$key}, $value_to_test, "\$report->{systempreferences}->{$key} = $value_to_test" );
593
        if ( $report->{systempreferences}->{$key} ne $value_to_test ) {
594
            warn $key;
595
            push @missings, $key;
596
        }
597
    }
598
    unless ( @missings ) {
599
        ok(1, 'All prefs are present');
600
    } else {
601
        ok(0, 'Some prefs are missing: ' . Dumper(\@missings));
591
    }
602
    }
592
}
603
}
593
604
594
- 

Return to bug 15131