From b8d7c3c8b6c609a442e9ff98704d9fcf8dc0d335 Mon Sep 17 00:00:00 2001 From: Fridolin Somers Date: Mon, 10 Oct 2016 16:46:04 +0200 Subject: [PATCH] Bug 17420 - record export fails when itemtype on biblio In Tools, Export data, you can export with a filter on item type. When item type is on biblio record, you get the error : export.pl: DBIx::Class::ResultSet::next(): Unknown column 'biblioitems.itemtype' in 'where clause' at /home/koha/src/Koha/Objects.pm line 150 Looks like its because this code use to be a SQL Select and is now a DBIx call : C4::Context->preference('item-level_itypes') ? ( 'items.itype' => $itemtype ) : ( 'me.itemtype' => $itemtype ) This patch corrects by using "me.itemtype" Test plan : - Use syspref item-level_itypes = biblio record - Go to Tools > Export data : /cgi-bin/koha/tools/export.pl - Select an item type - Click on "Export biblio records" => Without patch you get an error 500 => With patch you get a correct export file --- tools/export.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/export.pl b/tools/export.pl index c585d90..03792c3 100755 --- a/tools/export.pl +++ b/tools/export.pl @@ -139,7 +139,7 @@ if ( $op eq "export" ) { ? C4::Context->preference('item-level_itypes') ? ( 'items.itype' => $itemtype ) - : ( 'biblioitems.itemtype' => $itemtype ) + : ( 'me.itemtype' => $itemtype ) : () ), -- 2.7.4