Bugzilla – Attachment 56119 Details for
Bug 17417
Correct invalid markup around news on the staff client home page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17417 - Correct invalid markup around news on the staff client home page
Bug-17417---Correct-invalid-markup-around-news-on-.patch (text/plain), 2.21 KB, created by
Marc Véron
on 2016-10-10 19:03:24 UTC
(
hide
)
Description:
Bug 17417 - Correct invalid markup around news on the staff client home page
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2016-10-10 19:03:24 UTC
Size:
2.21 KB
patch
obsolete
>From aab0e171a31129b1d262944c5bc7d46f21d82641 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 10 Oct 2016 08:10:29 -0400 >Subject: [PATCH] Bug 17417 - Correct invalid markup around news on the staff > client home page > >This patch fixes two minor errors in the markup around displaying news >on the staff client home page: Adding a missing "class" attribute, and >changing the container around news items from <p> to <div> (because news >items might contain <p> and nesting them is incorrect). > >To test, apply the patch and view the staff client home page with news >items showing. Validate the page and confirm that there are no errors. > >Signed-off-by: Marc <veron@veron.ch> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt >index b251d9b..d6a3735 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt >@@ -180,11 +180,11 @@ var MSG_CONFIRM_DELETE = _("Are you sure you want to delete this news item? This > <div class="yui-b"><!-- YOUR NAVIGATION GOES HERE --> > [% IF ( koha_news_count ) %] > <div id="area-news"> >- <h3><span="news_title">News</span></h3> >+ <h3><span class="news_title">News</span></h3> > [% SET newsdisp = Koha.Preference('NewsAuthorDisplay') %] > [% FOREACH koha_new IN koha_news %] > <div class="newsitem" id="news[% koha_new.idnew %]"><h4>[% koha_new.title %]</h4> >- <p>[% koha_new.new %]</p> >+ <div class="newsbody">[% koha_new.new %]</div> > <p class="newsfooter"> Posted on [% koha_new.newdate %][% IF( ( newsdisp == 'staff' || newsdisp == 'both' ) && koha_new.borrowernumber ) %] by <span class="newsauthor_title">[% koha_new.author_title %] </span>[% koha_new.author_firstname %] [% koha_new.author_surname %]<br />[% END %] > [% IF ( CAN_user_tools ) %] > <a href="/cgi-bin/koha/tools/koha-news.pl?op=add_form&id=[% koha_new.idnew %]">Edit</a> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17417
:
56094
|
56119
|
56552
|
56745