Bugzilla – Attachment 56439 Details for
Bug 17442
Fees and charges warning on the circulation page. Rollback to the original behaviour
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17442 - Reinstate patron's fine warning that was lost with bug 14497
Bug-17442---Reinstate-patrons-fine-warning-that-wa.patch (text/plain), 2.88 KB, created by
Blou
on 2016-10-13 18:08:28 UTC
(
hide
)
Description:
Bug 17442 - Reinstate patron's fine warning that was lost with bug 14497
Filename:
MIME Type:
Creator:
Blou
Created:
2016-10-13 18:08:28 UTC
Size:
2.88 KB
patch
obsolete
>From 781346e534ba9cbae02645c76deb76e7d942ea70 Mon Sep 17 00:00:00 2001 >From: Francois Charbonnier <francois.charbonnier@inlibro.com> >Date: Thu, 13 Oct 2016 13:28:21 -0400 >Subject: [PATCH] Bug 17442 - Reinstate patron's fine warning that was lost > with bug 14497 > >Bug 14497 added a warning to patron details page if patron's fines exceed noissuescharge, but it also >changed the condition to display the warning on the circulation page. Until 16.05, the staff could see the >fees and charges warning on the circulation page when the patron had fines. But, with Bug 14497, the warning >appears only when the patron's fines exceed the noissuescharge syspref. > >This patch will keep the new warning on he patron detail page. >It will rollback the warning to the original behaviour. >The fees and charges warning will show up no matter how much the patron owes to the library. > >Test plan : > >1) Apply this patch >2) Find or create a patron who's fines doesn't exceed noissuescharge >3) You should see the fees and charges warning on the circulation page (circulation.pl) >4) Browse to the patron's details page (moremember.pl). The warning doesn't appear >5) Find or create a patron who's fines exceed noissuescharge >5) Browse to that patron's details ( moremember.pl ) >6) You should see a warning near the top of the page >--- > koha-tmpl/intranet-tmpl/prog/en/includes/fines.inc | 6 ++++++ > koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 2 +- > 2 files changed, 7 insertions(+), 1 deletion(-) > create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/fines.inc > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/fines.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/fines.inc >new file mode 100644 >index 0000000..15ccf81 >--- /dev/null >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/fines.inc >@@ -0,0 +1,6 @@ >+<li> >+<span class="circ-hlt">Fees & Charges:</span> Patron has <a href="/cgi-bin/koha/members/boraccount.pl?borrowernumber=[% borrowernumber %]">Outstanding fees & charges[% IF ( chargesamount ) %] of [% chargesamount %][% END %]</a>. >+[% IF ( charges_is_blocker ) %] >+Checkouts are <span class="circ-hlt">BLOCKED</span> because fine balance is <span class="circ-hlt">OVER THE LIMIT</span>. >+[% END %] >+<a href="/cgi-bin/koha/members/pay.pl?borrowernumber=[% borrowernumber %]">Make payment</a></li> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >index e0284b2..1ce3be6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >@@ -791,7 +791,7 @@ No patron matched <span class="ex">[% message | html %]</span> > [% END %] > > [% IF ( charges ) %] >- [% INCLUDE 'blocked-fines.inc' >+ [% INCLUDE 'fines.inc' > fines = chargesamount > %] > [% END %] >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17442
: 56439