Bugzilla – Attachment 57069 Details for
Bug 17535
Regression: Search for reports by keywords
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17535: Fix search for reports by keywords
Bug-17535-Fix-search-for-reports-by-keywords.patch (text/plain), 1.52 KB, created by
Jonathan Druart
on 2016-11-02 09:39:49 UTC
(
hide
)
Description:
Bug 17535: Fix search for reports by keywords
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-11-02 09:39:49 UTC
Size:
1.52 KB
patch
obsolete
>From 69ed39e7c4c51e96a75b2f1ba73245c11ca4692e Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 2 Nov 2016 09:36:53 +0000 >Subject: [PATCH] Bug 17535: Fix search for reports by keywords > >The commit cf9031711282f4be23e4a639797d0fd178940e1f > Bug 14435: Add the ability to store result's report >introduced a regression when searching for reports by keywords. >It also breaks tests in t/db_dependent/Reports/Guided.t > >It's caused by the missing join on saved_reports. >The error says DBD::mysql::db selectall_arrayref failed: Unknown column >'report' in 'where clause' > >Test plan: >Confirm that the tests are fixed and that you are able to search for >reports using the "keyword" input >--- > C4/Reports/Guided.pm | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/C4/Reports/Guided.pm b/C4/Reports/Guided.pm >index 62fdd7c..901edc4 100644 >--- a/C4/Reports/Guided.pm >+++ b/C4/Reports/Guided.pm >@@ -632,6 +632,7 @@ sub get_saved_reports_base_query { > SELECT s.*, $area_name_sql_snippet, av_g.lib AS groupname, av_sg.lib AS subgroupname, > b.firstname AS borrowerfirstname, b.surname AS borrowersurname > FROM saved_sql s >+LEFT JOIN saved_reports r ON r.report_id = s.id > LEFT OUTER JOIN authorised_values av_g ON (av_g.category = 'REPORT_GROUP' AND av_g.authorised_value = s.report_group) > LEFT OUTER JOIN authorised_values av_sg ON (av_sg.category = 'REPORT_SUBGROUP' AND av_sg.lib_opac = s.report_group AND av_sg.authorised_value = s.report_subgroup) > LEFT OUTER JOIN borrowers b USING (borrowernumber) >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17535
:
57069
|
57106
|
57229