From ebe3ff93d8cd89390345d154e0bbe37fceb44f38 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 2 Nov 2016 09:36:53 +0000 Subject: [PATCH] [SIGNED-OFF] Bug 17535: Fix search for reports by keywords The commit cf9031711282f4be23e4a639797d0fd178940e1f Bug 14435: Add the ability to store result's report introduced a regression when searching for reports by keywords. It also breaks tests in t/db_dependent/Reports/Guided.t It's caused by the missing join on saved_reports. The error says DBD::mysql::db selectall_arrayref failed: Unknown column 'report' in 'where clause' Test plan: Confirm that the tests are fixed and that you are able to search for reports using the "keyword" input Signed-off-by: Josef Moravec --- C4/Reports/Guided.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/C4/Reports/Guided.pm b/C4/Reports/Guided.pm index 62fdd7c..901edc4 100644 --- a/C4/Reports/Guided.pm +++ b/C4/Reports/Guided.pm @@ -632,6 +632,7 @@ sub get_saved_reports_base_query { SELECT s.*, $area_name_sql_snippet, av_g.lib AS groupname, av_sg.lib AS subgroupname, b.firstname AS borrowerfirstname, b.surname AS borrowersurname FROM saved_sql s +LEFT JOIN saved_reports r ON r.report_id = s.id LEFT OUTER JOIN authorised_values av_g ON (av_g.category = 'REPORT_GROUP' AND av_g.authorised_value = s.report_group) LEFT OUTER JOIN authorised_values av_sg ON (av_sg.category = 'REPORT_SUBGROUP' AND av_sg.lib_opac = s.report_group AND av_sg.authorised_value = s.report_subgroup) LEFT OUTER JOIN borrowers b USING (borrowernumber) -- 2.1.4