Attachment 57120 Details for Bug 16914 – Bug 16914: Insert end of line in CSV export of item search in translated templates

[patch] Bug 16914: Insert end of line in CSV export of item search in translated templates

Bug-16914-Insert-end-of-line-in-CSV-export-of-item.patch (text/plain), 2.39 KB, created by Josef Moravec on 2016-11-03 09:07:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Moravec

Created: 2016-11-03 09:07:32 UTC

Size: 2.39 KB

patch

obsolete

>From c041c04b27de46854647966fcd0f3998902220e3 Mon Sep 17 00:00:00 2001
>From: Josef Moravec <josef.moravec@gmail.com>
>Date: Thu, 3 Nov 2016 08:52:31 +0000
>Subject: [PATCH] Bug 16914: Insert end of line in CSV export of item search in
> translated templates
>
>Test plan:
>0) Do not apply the patch
>1) Install any translation
>2) Go to item search and choose Output to be CSV
>3) Search for at least 2 items in result set, open CSV in text editor
>    -> in english, everything is ok
>    -> in other languages are all data on one line
>4) Apply the patch
>5) Repeat steps 2 and 3, CSV should look OK either in english and other
>languages
>---
> .../intranet-tmpl/prog/en/includes/catalogue/itemsearch_item.csv.inc   | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_item.csv.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_item.csv.inc
>index 82e014c..3eb300d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_item.csv.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_item.csv.inc
>@@ -2,4 +2,5 @@
> [%- USE Koha -%]
> [%- biblio = item.biblio -%]
> [%- biblioitem = item.biblioitem -%]
>-"[% biblio.title |html %] [% IF ( Koha.Preference( 'marcflavour' ) == 'UNIMARC' && biblio.author ) %]by [% END %][% biblio.author |html %]", "[% (biblioitem.publicationyear || biblio.copyrightdate) |html %]", "[% biblioitem.publishercode |html %]", "[% biblioitem.collectiontitle |html %]", "[% item.barcode |html %]", "[% item.itemcallnumber |html %]", "[% Branches.GetName(item.homebranch) |html %]", "[% Branches.GetName(item.holdingbranch) |html %]", "[% item.location |html %]", "[% item.stocknumber |html %]", "[% item.status |html %]", "[% (item.issues || 0) |html %]"[% INCLUDE 'empty_line.inc' %]
>+"[% biblio.title |html %] [% IF ( Koha.Preference( 'marcflavour' ) == 'UNIMARC' && biblio.author ) %]by [% END %][% biblio.author |html %]", "[% (biblioitem.publicationyear || biblio.copyrightdate) |html %]", "[% biblioitem.publishercode |html %]", "[% biblioitem.collectiontitle |html %]", "[% item.barcode |html %]", "[% item.itemcallnumber |html %]", "[% Branches.GetName(item.homebranch) |html %]", "[% Branches.GetName(item.holdingbranch) |html %]", "[% item.location |html %]", "[% item.stocknumber |html %]", "[% item.status |html %]", "[% (item.issues || 0) |html %]"
>+[% INCLUDE 'empty_line.inc' %]
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 16914: 57120 | 57388 | 58380 | 58396 | 58397 | 58400 | 58401 | 58402 | 58403