From 4ebeea54c16c8d10641db15ef05cb2077948cd2e Mon Sep 17 00:00:00 2001
From: Lari Taskula <lari.taskula@jns.fi>
Date: Wed, 2 Nov 2016 14:51:23 +0200
Subject: [PATCH] Bug 17539: Fix Undefined subroutine
&C4::Circulation::GetItem error
Content-Type: text/plain; charset=utf-8
perl t/db_dependent/Reserves.t
1..72
ok 1 - use C4::Reserves;
ok 2 - CheckReserves Test 1
ok 3 - CheckReserves() include reserve_id in its response
ok 4 - CheckReserves Test 2
ok 5 - CheckReserves Test 3
ok 6 - GetReservesControlBranch returns item home branch when set to ItemHomeLibrary
ok 7 - GetReservesControlBranch returns patron home branch when set to PatronLibrary
ok 8 - Item is correctly waiting
ok 9 - Item is correctly priority 1
ok 10 - Item is correctly priority 2
ok 11 - GetWaiting got only the waiting reserve
ok 12 - GetWaiting got the reserve for the correct borrower
Undefined subroutine &C4::Circulation::GetItem called at /home/ubuntu/kohaclone/C4/Circulation.pm line 1853.
This patch fixes this error. The solution was to use C4::Reserves before C4::Items.
Also due to this edit, change use_ok to require_ok
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
---
t/db_dependent/Reserves.t | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t
index 39ee8c5..1e9a067 100755
--- a/t/db_dependent/Reserves.t
+++ b/t/db_dependent/Reserves.t
@@ -25,6 +25,7 @@ use MARC::Record;
use DateTime::Duration;
use C4::Biblio;
+use C4::Reserves;
use C4::Items;
use C4::Members;
use C4::Circulation;
@@ -37,7 +38,7 @@ use Koha::Patron::Categories;
use Data::Dumper;
BEGIN {
- use_ok('C4::Reserves');
+ require_ok('C4::Reserves');
}
# a very minimal mack of userenv for use by the test of DelItemCheck
--
1.7.10.4