Bugzilla – Attachment 57168 Details for
Bug 15906
Remove use of makepayment in paycollect.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15906 - Remove use of makepayment in paycollect.pl
Bug-15906---Remove-use-of-makepayment-in-paycollec.patch (text/plain), 1.59 KB, created by
Marcel de Rooy
on 2016-11-04 09:46:18 UTC
(
hide
)
Description:
Bug 15906 - Remove use of makepayment in paycollect.pl
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2016-11-04 09:46:18 UTC
Size:
1.59 KB
patch
obsolete
>From b8db5b8462dd034472c00031f7a9ca8d7563e818 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 24 Feb 2016 15:51:07 +0000 >Subject: [PATCH] Bug 15906 - Remove use of makepayment in paycollect.pl >Content-Type: text/plain; charset=utf-8 > >Test plan: >1) Apply this patch >2) Make a payment in full using the "Pay" button >3) Note payment succeeds > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > members/paycollect.pl | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > >diff --git a/members/paycollect.pl b/members/paycollect.pl >index 1cb6ad9..b341e8c 100755 >--- a/members/paycollect.pl >+++ b/members/paycollect.pl >@@ -112,8 +112,15 @@ if ( $total_paid and $total_paid ne '0.00' ) { > } else { > if ($individual) { > if ( $total_paid == $total_due ) { >- makepayment( $accountlines_id, $borrowernumber, $accountno, $total_paid, $user, >- $branch, $payment_note ); >+ my $line = Koha::Account::Lines->find($accountlines_id); >+ Koha::Account->new( { patron_id => $borrowernumber } )->pay( >+ { >+ lines => [$line], >+ amount => $total_paid, >+ library_id => $branch, >+ note => $payment_note >+ } >+ ); > } else { > makepartialpayment( $accountlines_id, $borrowernumber, $accountno, $total_paid, > $user, $branch, $payment_note ); >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15906
:
48347
|
52135
|
52148
|
54172
| 57168 |
57169