From f4a978d57adcbd4722d864693308524b5c87d27b Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Mon, 7 Nov 2016 15:31:53 -0300 Subject: [PATCH] Bug 17574: Remove itemtype-related warnings from LocalHoldsPriority.t To test: - Run: $ prove t/db_dependent/Holds/LocalHoldsPriority.t => FAIL: Tests raise lots of warnings - Apply the patch - Run: $ prove t/db_dependent/Holds/LocalHoldsPriority.t => SUCCESS: Tests pass, and no warnings! - Sign off :-D Sponsored-by: ByWater Solutions --- t/db_dependent/Holds/LocalHoldsPriority.t | 33 ++++++++++++++++++------------- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/t/db_dependent/Holds/LocalHoldsPriority.t b/t/db_dependent/Holds/LocalHoldsPriority.t index 7ccc843..ef40686 100755 --- a/t/db_dependent/Holds/LocalHoldsPriority.t +++ b/t/db_dependent/Holds/LocalHoldsPriority.t @@ -25,26 +25,31 @@ $schema->storage->txn_begin; my $builder = t::lib::TestBuilder->new; -my $library1 = $builder->build({ - source => 'Branch', -}); -my $library2 = $builder->build({ - source => 'Branch', -}); -my $library3 = $builder->build({ - source => 'Branch', -}); -my $library4 = $builder->build({ - source => 'Branch', -}); +my $library1 = $builder->build({ source => 'Branch', }); +my $library2 = $builder->build({ source => 'Branch', }); +my $library3 = $builder->build({ source => 'Branch', }); +my $library4 = $builder->build({ source => 'Branch', }); +my $itemtype = $builder->build( + { source => 'Itemtype', + value => { notforloan => undef, rentalcharge => 0 } + } +)->{itemtype}; + + my $borrowers_count = 5; # Create a helper biblio my ( $bibnum, $title, $bibitemnum ) = create_helper_biblio(); # Create a helper item for the biblio. -my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = - AddItem( { homebranch => $library4->{branchcode}, holdingbranch => $library3->{branchcode} }, $bibnum ); +my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = AddItem( + { homebranch => $library4->{branchcode}, + holdingbranch => $library3->{branchcode}, + itype => $itemtype + }, + $bibnum +); + my @branchcodes = ( $library1->{branchcode}, $library2->{branchcode}, $library3->{branchcode}, $library4->{branchcode}, $library3->{branchcode}, $library4->{branchcode} ); -- 2.10.2