Bugzilla – Attachment 57287 Details for
Bug 17573
Remove DecreaseLoanHighHolds.t warnings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 17573: Remove itemtype-related warnings from DecreaseLoanHighHolds.t
SIGNED-OFF-Bug-17573-Remove-itemtype-related-warni.patch (text/plain), 1.66 KB, created by
Josef Moravec
on 2016-11-07 21:30:21 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 17573: Remove itemtype-related warnings from DecreaseLoanHighHolds.t
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2016-11-07 21:30:21 UTC
Size:
1.66 KB
patch
obsolete
>From 912bd99b2e697e18f69dfd2af7bb6e0a39f09fe9 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Mon, 7 Nov 2016 15:24:34 -0300 >Subject: [PATCH] [SIGNED-OFF] Bug 17573: Remove itemtype-related warnings from > DecreaseLoanHighHolds.t > >To test: >- Run: > $ prove t/db_dependent/DecreaseLoanHighHolds.t >=> FAIL: Lots of warnings >- Apply the patch >- Run: > $ prove t/db_dependent/DecreaseLoanHighHolds.t >=> SUCCESS: All green and no warnings. >- Sign off :-D > >Sponsored-by: ByWater Solutions > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > t/db_dependent/DecreaseLoanHighHolds.t | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/DecreaseLoanHighHolds.t b/t/db_dependent/DecreaseLoanHighHolds.t >index 3eb8e6b..ca14fb4 100755 >--- a/t/db_dependent/DecreaseLoanHighHolds.t >+++ b/t/db_dependent/DecreaseLoanHighHolds.t >@@ -41,8 +41,9 @@ $dbh->do('DELETE FROM issuingrules'); > $dbh->do('DELETE FROM borrowers'); > $dbh->do('DELETE FROM items'); > >-my $library = $builder->build({source => 'Branch'}); >-my $category = $builder->build({source => 'Category'}); >+my $library = $builder->build( { source => 'Branch' } ); >+my $category = $builder->build( { source => 'Category' } ); >+my $itemtype = $builder->build( { source => 'Itemtype' } )->{itemtype}; > > # Set userenv > C4::Context->_new_userenv('xxx'); >@@ -67,7 +68,8 @@ for my $i ( 1 .. 10 ) { > { > biblionumber => $biblio->id(), > biblioitemnumber => $biblioitem->id(), >- barcode => $i >+ barcode => $i, >+ itype => $itemtype > } > )->store(); > push( @items, $item ); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17573
:
57274
|
57287
|
57453