Attachment 57428 Details for Bug 4126 – Bug 4126 - Exit bulkmarcimport if -a and -b given

[patch] Bug 4126 - Exit bulkmarcimport if -a and -b given

Bug-4126---Exit-bulkmarcimport-if--a-and--b-given.patch (text/plain), 1.46 KB, created by Magnus Enger on 2016-11-10 14:40:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Magnus Enger

Created: 2016-11-10 14:40:45 UTC

Size: 1.46 KB

patch

obsolete

>From 2fa01f54fd2fe932f128800c7652a5223be37db5 Mon Sep 17 00:00:00 2001
>From: Magnus Enger <magnus@libriotech.no>
>Date: Thu, 10 Nov 2016 14:32:44 +0000
>Subject: [PATCH] Bug 4126 - Exit bulkmarcimport if -a and -b given
>
>Currently it is possible to spceify both --biblios and --authorities
>as command line switches to bulkmarcimport.pl. This does not make sense
>so we should exit early and explain that these switches are mutually
>exclusive.
>
>To test:
>- Run one of these and check that there is no complaint about missing
>  options:
>  perl misc/migration_tools/bulkmarcimport.pl -a -b
>  sudo koha-shell -c "perl misc/migration_tools/bulkmarcimport.pl -a -b"
>  kohadev
>- Observe that this displays the perldoc, but does not complain about
>  mutually exclusive switches.
>- Apply the patch
>- Rerun the command(s) from earlier.
>- Verify that the script is now halted and a small explanation given.
>---
> misc/migration_tools/bulkmarcimport.pl | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/misc/migration_tools/bulkmarcimport.pl b/misc/migration_tools/bulkmarcimport.pl
>index d007d29..34d2b52 100755
>--- a/misc/migration_tools/bulkmarcimport.pl
>+++ b/misc/migration_tools/bulkmarcimport.pl
>@@ -84,6 +84,8 @@ $biblios ||= !$authorities;
> $insert  ||= !$update;
> my $writemode = ($append) ? "a" : "w";
> 
>+pod2usage( -msg => "\nYou must specify either --biblios or --authorities, not both.\n", -exitval ) if $biblios && $authorities;
>+
> if ($all) {
>     $insert = 1;
>     $update = 1;
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 4126: 57428 | 58833 | 59618