From 056e00d6ca3144269f808018fbe8d793eb899380 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Tue, 15 Nov 2016 11:10:51 +0000
Subject: [PATCH] Bug 17629: Koha::Biblio - Remove ModBiblioframework
There is only one call to C4::Biblio::ModBiblioframework, it's called
just before C4::Biblio::ModBiblio in cataloguing/addbiblio.pl
At first glance this call does not seems useful: all the subroutines
called from ModBiblio send the frameworkcode in parameter.
I'd go to remove it, but I'd like to get confirmation by others.
No test plan here, you need a good pair of eyes and deep into the
C4::Biblio code.
---
C4/Biblio.pm | 17 -----------------
cataloguing/addbiblio.pl | 1 -
t/db_dependent/00-strict.t | 24 ------------------------
3 files changed, 42 deletions(-)
delete mode 100644 t/db_dependent/00-strict.t
diff --git a/C4/Biblio.pm b/C4/Biblio.pm
index 6d64e80..b00a10a 100644
--- a/C4/Biblio.pm
+++ b/C4/Biblio.pm
@@ -110,7 +110,6 @@ BEGIN {
# To modify something
push @EXPORT, qw(
&ModBiblio
- &ModBiblioframework
&ModZebra
&UpdateTotalIssues
&RemoveAllNsb
@@ -386,22 +385,6 @@ sub _strip_item_fields {
}
}
-=head2 ModBiblioframework
-
- ModBiblioframework($biblionumber,$frameworkcode);
-
-Exported function to modify a biblio framework
-
-=cut
-
-sub ModBiblioframework {
- my ( $biblionumber, $frameworkcode ) = @_;
- my $dbh = C4::Context->dbh;
- my $sth = $dbh->prepare( "UPDATE biblio SET frameworkcode=? WHERE biblionumber=?" );
- $sth->execute( $frameworkcode, $biblionumber );
- return 1;
-}
-
=head2 DelBiblio
my $error = &DelBiblio($biblionumber);
diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl
index 4615998..1929d0c 100755
--- a/cataloguing/addbiblio.pl
+++ b/cataloguing/addbiblio.pl
@@ -837,7 +837,6 @@ if ( $op eq "addbiblio" ) {
BiblioAutoLink( $record, $frameworkcode );
}
if ( $is_a_modif ) {
- ModBiblioframework( $biblionumber, $frameworkcode );
ModBiblio( $record, $biblionumber, $frameworkcode );
}
else {
diff --git a/t/db_dependent/00-strict.t b/t/db_dependent/00-strict.t
deleted file mode 100644
index 688b449..0000000
--- a/t/db_dependent/00-strict.t
+++ /dev/null
@@ -1,24 +0,0 @@
-# This script is called by the pre-commit git hook to test modules compile
-
-use strict;
-use warnings;
-use Test::More;
-use Test::Strict;
-use File::Spec;
-use File::Find;
-use lib("misc/translator");
-use lib("installer");
-
-my @dirs = ( 'acqui', 'admin', 'authorities', 'basket',
- 'catalogue', 'cataloguing', 'changelanguage.pl', 'circ', 'debian', 'docs',
- 'edithelp.pl', 'errors', 'fix-perl-path.PL', 'help.pl', 'installer',
- 'koha_perl_deps.pl', 'kohaversion.pl', 'labels',
- 'mainpage.pl', 'Makefile.PL', 'members', 'misc', 'offline_circ', 'opac',
- 'patroncards', 'reports', 'reserve', 'resetversion.pl', 'reviews',
- 'rewrite-config.PL', 'rotating_collections', 'serials', 'services', 'skel',
- 'sms', 'suggestion', 'svc', 'tags', 'tools', 'virtualshelves' );
-
-$Test::Strict::TEST_STRICT = 0;
-$Test::Strict::TEST_SKIP = [ 'misc/kohalib.pl', 'sms/sms_listen_windows_start.pl', 'misc/plack/koha.psgi' ];
-
-all_perl_files_ok(@dirs);
--
2.1.4