From ff77f729f31eff4d44b60808380bec3b4bd408cf Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 15 Nov 2016 15:49:00 +0000 Subject: [PATCH] Bug 17599: Make the tests pass If you run TooMany or MultiplePerRecord.t after t/db_dependent/Circulation/Returns.t (for instance) and that you are running memcached, item-level_itypes will be 0. These tests assume that the pref is 1 --- t/db_dependent/Circulation/TooMany.t | 1 + t/db_dependent/Reserves/MultiplePerRecord.t | 3 +++ 2 files changed, 4 insertions(+) diff --git a/t/db_dependent/Circulation/TooMany.t b/t/db_dependent/Circulation/TooMany.t index d066809..0e129c3 100644 --- a/t/db_dependent/Circulation/TooMany.t +++ b/t/db_dependent/Circulation/TooMany.t @@ -50,6 +50,7 @@ $dbh->do(q|DELETE FROM default_branch_item_rules|); $dbh->do(q|DELETE FROM issuingrules|); my $builder = t::lib::TestBuilder->new(); +t::lib::Mocks::mock_preference('item-level_itypes', 1); # Assuming the item type is defined at item level my $branch = $builder->build({ source => 'Branch', diff --git a/t/db_dependent/Reserves/MultiplePerRecord.t b/t/db_dependent/Reserves/MultiplePerRecord.t index d2da653..559cef4 100755 --- a/t/db_dependent/Reserves/MultiplePerRecord.t +++ b/t/db_dependent/Reserves/MultiplePerRecord.t @@ -21,6 +21,7 @@ use Modern::Perl; use Test::More tests => 38; use t::lib::TestBuilder; +use t::lib::Mocks; use C4::Reserves qw( GetMaxPatronHoldsForRecord AddReserve CanBookBeReserved ); use Koha::Database; @@ -119,6 +120,8 @@ my $rule1 = $rules_rs->new( } )->insert(); +t::lib::Mocks::mock_preference('item-level_itypes', 1); # Assuming the item type is defined at item level + my $max = GetMaxPatronHoldsForRecord( $patron->{borrowernumber}, $biblio->{biblionumber} ); is( $max, 1, 'GetMaxPatronHoldsForRecord returns max of 1' ); my $rule = C4::Reserves::GetHoldRule( -- 2.1.4