From f427166215fbeb4458b8deea9d65d0aa902bb3b6 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Wed, 16 Nov 2016 12:48:11 -0300 Subject: [PATCH] Bug 17640: (QA followup) Add more tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall --- t/db_dependent/Template/Plugin/Categories.t | 45 ++++++++++++++++++++++++++--- 1 file changed, 41 insertions(+), 4 deletions(-) diff --git a/t/db_dependent/Template/Plugin/Categories.t b/t/db_dependent/Template/Plugin/Categories.t index 014cab2..d361986 100644 --- a/t/db_dependent/Template/Plugin/Categories.t +++ b/t/db_dependent/Template/Plugin/Categories.t @@ -1,6 +1,23 @@ +#!/usr/bin/perl + +# This file is part of Koha. +# +# Koha is free software; you can redistribute it and/or modify it +# under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# Koha is distributed in the hope that it will be useful, but +# WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with Koha; if not, see . + use Modern::Perl; -use Test::More tests => 1; +use Test::More tests => 4; use Koha::Database; use Koha::Template::Plugin::Categories; @@ -9,11 +26,31 @@ use t::lib::TestBuilder; my $schema = Koha::Database->new->schema; $schema->storage->txn_begin; +# Delete all categories +$schema->resultset('Borrower')->search->delete; +$schema->resultset('Category')->search->delete; + my $builder = t::lib::TestBuilder->new; -$builder->build({ source => 'Category' }); +is( Koha::Template::Plugin::Categories->new->all->count, + 0, '->all returns 0 results if no categories defined' ); + +# Create sample categories +my $category_1 = $builder->build( { source => 'Category' } ); my @categories = Koha::Template::Plugin::Categories->new->all; -isnt( scalar( @categories ), 0, 'Plugin Categories should return categories' ); -my $selected_categories = [ grep { $_->{selected} } @categories ]; +is( scalar(@categories), 1, '->all returns all defined categories' ); + +my $category_2 = $builder->build( { source => 'Category' } ); +@categories = Koha::Template::Plugin::Categories->new->all; +is( scalar(@categories), 2, '->all returns all defined categories' ); + +is( Koha::Template::Plugin::Categories->GetName( + $category_1->{categorycode} + ), + $category_1->{description}, + '->GetName returns the right description' +); $schema->storage->txn_rollback; + +1; -- 2.1.4