Bugzilla – Attachment 57597 Details for
Bug 17502
Add type check to output_pref and use exceptions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17502: [Follow-up] Better use the str parameter
Bug-17502-Follow-up-Better-use-the-str-parameter.patch (text/plain), 1.31 KB, created by
Marcel de Rooy
on 2016-11-17 13:01:22 UTC
(
hide
)
Description:
Bug 17502: [Follow-up] Better use the str parameter
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2016-11-17 13:01:22 UTC
Size:
1.31 KB
patch
obsolete
>From c9f7049ba6e44a5bdf19686d091b4d9b22972a44 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Thu, 17 Nov 2016 13:55:08 +0100 >Subject: [PATCH] Bug 17502: [Follow-up] Better use the str parameter >Content-Type: text/plain; charset=utf-8 > >Constructions like > output_pref({ dt => dt_from_string( $str ), ... >could be simplified with > output_pref({ str => $str, ... > >Test plan: >See previous plan. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Search.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Search.pm b/C4/Search.pm >index 2867d50..a18f202 100644 >--- a/C4/Search.pm >+++ b/C4/Search.pm >@@ -2084,7 +2084,7 @@ sub searchResults { > { > $onloan_count++; > my $key = $prefix . $item->{onloan} . $item->{barcode}; >- $onloan_items->{$key}->{due_date} = output_pref( { dt => scalar dt_from_string( $item->{onloan} ), dateonly => 1 } ); >+ $onloan_items->{$key}->{due_date} = output_pref({ str => $item->{onloan}, dateonly => 1 }); > $onloan_items->{$key}->{count}++ if $item->{$hbranch}; > $onloan_items->{$key}->{branchname} = $item->{branchname}; > $onloan_items->{$key}->{location} = $shelflocations->{ $item->{location} }; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17502
:
56916
|
56917
|
57597
|
61458
|
61510
|
61518
|
61519
|
62168
|
62169
|
62408
|
62409
|
62410