From 0a33b2598c04f83851fb9765cbc27315a96dc674 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Fri, 2 Dec 2016 15:21:58 -0300 Subject: [PATCH] [SIGNED-OFF] Bug 17716: Remove itemtype-related t/db_dependent/CourseReserves.t This patch makes t/db_dependent/CourseReserves.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/CourseReserves.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/CourseReserves.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Signed-off-by: Mark Tompsett --- t/db_dependent/CourseReserves.t | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/t/db_dependent/CourseReserves.t b/t/db_dependent/CourseReserves.t index d893890..720fb78 100755 --- a/t/db_dependent/CourseReserves.t +++ b/t/db_dependent/CourseReserves.t @@ -25,9 +25,9 @@ my $builder = t::lib::TestBuilder->new; my $dbh = C4::Context->dbh; $dbh->{RaiseError} = 1; -my $library = $builder->build({ - source => 'Branch', -}); +my $library = $builder->build( { source => 'Branch' } ); +my $itemtype = $builder->build( + { source => 'Itemtype', value => { notforloan => undef } } )->{itemtype}; my $sth = $dbh->prepare("SELECT * FROM borrowers ORDER BY RAND() LIMIT 10"); $sth->execute(); @@ -39,7 +39,13 @@ $record->append_fields( MARC::Field->new( '952', '0', '0', a => $library->{branchcode}, b => $library->{branchcode} ) ); my ( $biblionumber, $biblioitemnumber ) = C4::Biblio::AddBiblio($record, ''); -my @iteminfo = C4::Items::AddItem( { homebranch => $library->{branchcode}, holdingbranch => $library->{branchcode} }, $biblionumber ); +my @iteminfo = C4::Items::AddItem( + { homebranch => $library->{branchcode}, + holdingbranch => $library->{branchcode}, + itype => $itemtype + }, + $biblionumber +); my $itemnumber = $iteminfo[2]; my $course_id = ModCourse( -- 2.1.4