From 8a45a2a6bb2687d85a15931de6d43682d2b84c4d Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Mon, 21 Nov 2016 08:26:13 -0500 Subject: [PATCH] Bug 11274 Sent Notices Tab Not Working Correctly This patch implements the notices toggle event using a different method. Using on() lets us bind the event to a parent element, allowing the event to attach to elements which may not exist on the page yet. Test plan the same as original patch: 1) have a patron with more then 20 notices sent 2) go to patron profile -> notices -> without patch, the showing/hidding of notices content does work correctly only on first loaded page -> with patch, it should work correctly everywhere - try to use paginator, searching, ordering.... Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart --- .../intranet-tmpl/prog/en/modules/members/notices.tt | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt index 662a72e..0d8b7d5 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt @@ -16,18 +16,18 @@ "sPaginationType": "four_button" })); - $(".notice").hide(); - $(".notice-title").click(function(e){ - $(this).closest("tr").children().children(".notice").toggle(); - e.preventDefault(); - }); - + $("#noticestable").on("click", ".notice-title", function(e){ + e.preventDefault(); + var rowid = $(this).data("noticeid"); + $("#notice"+rowid).toggle(); + }); + }); //]]> @@ -57,8 +57,8 @@ [% FOREACH QUEUED_MESSAGE IN QUEUED_MESSAGES %] - [% QUEUED_MESSAGE.subject %] -
+ [% QUEUED_MESSAGE.subject %] +
[% QUEUED_MESSAGE.content FILTER html_line_break %]
-- 2.9.3