From 4f86cd78b4048efa7197a7c7588e8e911c847013 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 16 Dec 2016 10:58:40 +0100 Subject: [PATCH] Bug 15108: [QA Follow-up] Serious doubts on ResumptionToken::deleted Content-Type: text/plain; charset=utf-8 ListBase: Remove a comma construction by two statements. ResumptionToken: Tidy sub deleted, added FIXME. Signed-off-by: Marcel de Rooy --- Koha/OAI/Server/ListBase.pm | 3 ++- Koha/OAI/Server/ResumptionToken.pm | 11 +++++++++-- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/Koha/OAI/Server/ListBase.pm b/Koha/OAI/Server/ListBase.pm index e225371..a6abf6d 100644 --- a/Koha/OAI/Server/ListBase.pm +++ b/Koha/OAI/Server/ListBase.pm @@ -162,7 +162,8 @@ sub GetRecords { ) ); } } else { - $timestamp =~ s/ /T/, $timestamp .= 'Z'; + $timestamp =~ s/ /T/; + $timestamp .= 'Z'; $self->identifier( new HTTP::OAI::Header( identifier => $repository->{ koha_identifier} . ':' . $biblionumber, datestamp => $timestamp, diff --git a/Koha/OAI/Server/ResumptionToken.pm b/Koha/OAI/Server/ResumptionToken.pm index 7062573..92ef1dd 100644 --- a/Koha/OAI/Server/ResumptionToken.pm +++ b/Koha/OAI/Server/ResumptionToken.pm @@ -34,8 +34,6 @@ use base ("HTTP::OAI::ResumptionToken"); # - offset # - deleted -sub deleted { shift->_elem('deleted',@_) } - sub new { my ($class, %args) = @_; @@ -78,6 +76,15 @@ sub new { return $self; } +sub deleted { +# FIXME It seems that this sub is not used and that if it would be +# used, it would not return what you expect (since deleted is not +# found in the _elem hash). +# Note: sub _elem is found in HTTP::OAI::Encapsulation. + my $self = shift; + return $self->_elem( 'deleted', @_ ); +} + sub _strip_UTC_designators { my ( $timestamp ) = @_; $timestamp =~ s/T/ /g; -- 2.1.4