Bugzilla – Attachment 58314 Details for
Bug 17783
Optimize Koha::IssuingRules->get_effective_issuing_rule
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17783: Replace ok with is
Bug-17783-Replace-ok-with-is.patch (text/plain), 1.42 KB, created by
Jonathan Druart
on 2016-12-20 17:08:25 UTC
(
hide
)
Description:
Bug 17783: Replace ok with is
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-12-20 17:08:25 UTC
Size:
1.42 KB
patch
obsolete
>From 377fa87b18097648b7a1aebc31a17586f02f59c1 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 20 Dec 2016 18:07:40 +0100 >Subject: [PATCH] Bug 17783: Replace ok with is > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >--- > t/db_dependent/Koha/IssuingRules.t | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Koha/IssuingRules.t b/t/db_dependent/Koha/IssuingRules.t >index 847f971..2285be1 100644 >--- a/t/db_dependent/Koha/IssuingRules.t >+++ b/t/db_dependent/Koha/IssuingRules.t >@@ -47,7 +47,8 @@ subtest 'get_effective_issuing_rule' => sub { > > my $rule; > Koha::IssuingRules->delete; >- ok(!Koha::IssuingRules->search->count, 'There are no issuing rules.'); >+ >+ is(Koha::IssuingRules->search->count, 0, 'There are no issuing rules.'); > $rule = Koha::IssuingRules->get_effective_issuing_rule({ > branchcode => undef, > categorycode => undef, >@@ -76,7 +77,7 @@ subtest 'get_effective_issuing_rule' => sub { > > my $rule; > Koha::IssuingRules->delete; >- ok(!Koha::IssuingRules->search->count, 'There are no issuing rules.'); >+ is(Koha::IssuingRules->search->count, 0, 'There are no issuing rules.'); > $rule = Koha::IssuingRules->get_effective_issuing_rule({ > branchcode => $branchcode, > categorycode => $categorycode, >-- >2.9.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17783
:
58228
|
58229
|
58230
|
58231
|
58268
|
58269
|
58270
|
58271
|
58300
|
58304
|
58309
|
58310
|
58311
|
58312
|
58313
| 58314