Bugzilla – Attachment 5844 Details for
Bug 7006
highlight patron changes in email
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed fix
0001-Fix-for-Bug-7006-highlight-patron-changes-in-email.patch (text/plain), 2.02 KB, created by
Owen Leonard
on 2011-10-11 20:00:20 UTC
(
hide
)
Description:
Proposed fix
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2011-10-11 20:00:20 UTC
Size:
2.02 KB
patch
obsolete
>From 4cc821f9b9aa87de4d4e11213e646ff540d007dc Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 11 Oct 2011 15:56:10 -0400 >Subject: [PATCH] Fix for Bug 7006, highlight patron changes in email >Content-Type: text/plain; charset="utf-8" > >This patch eliminates all unchanged fields from the email >on the assumption that the information is superfluous. I have >also added a link to the patron edit screen which will be >displayed if the staffClientBaseURL has been entered. >--- > opac/opac-userupdate.pl | 14 +++++++------- > 1 files changed, 7 insertions(+), 7 deletions(-) > >diff --git a/opac/opac-userupdate.pl b/opac/opac-userupdate.pl >index f8273ce..b6586a6 100755 >--- a/opac/opac-userupdate.pl >+++ b/opac/opac-userupdate.pl >@@ -89,10 +89,9 @@ if ( $query->param('modify') ) { > > # get all the fields: > my $message = <<"EOF"; >-Patron $borr->{'cardnumber'} >+Patron $borr->{'cardnumber'} has requested to change her/his personal details. >+Please check these new details and make the changes to these fields: > >-has requested to change her/his personal details. >-Please check these new details and make the changes: > EOF > > my $streetnumber = $borr->{'streetnumber'} || ''; >@@ -113,12 +112,13 @@ EOF > $borrowerfield = format_date( $borr->{'dateofbirth'} ) || ''; > } > >- if($borrowerfield eq $newfield) { >- $message .= "$field : $borrowerfield --> $newfield\n"; >- } else { >- $message .= uc($field) . " : $borrowerfield --> $newfield\n"; >+ if($borrowerfield ne $newfield) { >+ $message .= $field . " : $borrowerfield --> $newfield\n"; > } > } >+ >+ $message .= "\nEdit this patron's record: http://".C4::Context->preference('staffClientBaseURL ')."/cgi-bin/koha/members/memberentry.pl?op=modify&borrowernumber=".$borr->{'borrowernumber'}."&categorycode=".$borr->{'categorycode'} if C4::Context->preference('staffClientBaseURL '); >+ > $message .= "\n\nThanks,\nKoha\n\n"; > my %mail = ( > To => $updateemailaddress, >-- >1.7.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7006
:
5844
|
5845
|
6861