From 14478731e48aebbcbfbe7143d63790110aaf4908 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Wed, 28 Dec 2016 10:20:16 +0000
Subject: [PATCH] Bug 17817:  Temporarily remove select2 where is is used

If you try to clone a field (or subfield) which contains at least a
subfield linked to authorized values, you will get a JS error and the
field will not be cloned.

I have failed trying to propose a fix in a reasonable delay so I prefer
to simply deactivate the feature.

Test plan:
Edit a bibliographic record, an item and use the batch item modification
tool.
You should see simple selects
---
 koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt | 7 ++++---
 koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt   | 7 ++++---
 koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt   | 7 ++++---
 3 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
index 1aa98ed..3b7e934 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
@@ -384,9 +384,10 @@ function Changefwk() {
 
 [% INCLUDE 'select2.inc' %]
 <script>
-  $(document).ready(function() {
-    $('.subfield_line select').select2();
-  });
+  [%# FIXME This is broken and should be fixed, see bug 17817 %]
+  //$(document).ready(function() {
+  //  $('.subfield_line select').select2();
+  //});
 </script>
 
 [% IF ( bidi ) %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
index db83ef8..10b630a 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
@@ -130,9 +130,10 @@ function confirm_deletion() {
 
 [% INCLUDE 'select2.inc' %]
 <script type="text/javascript">
-  $(document).ready(function() {
-    $('.subfield_line select').select2();
-  });
+  [%# FIXME This is broken and should be fixed, see bug 17817 %]
+  //$(document).ready(function() {
+  //  $('.subfield_line select').select2();
+  //});
 </script>
 
 [% IF ( bidi ) %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt
index 5eb138e..dfc2390 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt
@@ -46,9 +46,10 @@ $(document).ready(function(){
 
 [% INCLUDE 'select2.inc' %]
 <script type="text/javascript">
-  $(document).ready(function() {
-    $('.subfield_line select').select2();
-  });
+  [%# FIXME This is broken and should be fixed, see bug 17817 %]
+  //$(document).ready(function() {
+  //  $('.subfield_line select').select2();
+  //});
 </script>
 
 </head>
-- 
2.1.4