From 638a0557b75eaa7cd4a4996cd85e59b7f638b854 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 28 Dec 2016 13:51:17 +0000 Subject: [PATCH] [SIGNED-OFF] Bug 7533: Add a warning to the about page if template_cache_dir is not set We need to tell the administrators that it would be great for them to set this config entry. Test plan: - Do not set template_cache_dir and confirm that you see the warning - Set template_cache_dir and confirm that you do not see the warning Signed-off-by: Magnus Enger Both templates for koha-conf.xml are updated. After applying the patach a warning was correctly displayed. After adding template_cache_dir to koha-conf.xml and restarting memcached it went away. --- about.pl | 2 ++ koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 10 ++++++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/about.pl b/about.pl index fc16079..f0b0499 100755 --- a/about.pl +++ b/about.pl @@ -128,6 +128,7 @@ my $errZebraConnection = C4::Context->Zconn("biblioserver",0)->errcode(); my $warnIsRootUser = (! $loggedinuser); my $warnNoActiveCurrency = (! defined Koha::Acquisition::Currencies->get_active); + my @xml_config_warnings; my $context = new C4::Context; @@ -307,6 +308,7 @@ $template->param( errZebraConnection => $errZebraConnection, warnIsRootUser => $warnIsRootUser, warnNoActiveCurrency => $warnNoActiveCurrency, + warnNoTemplateCaching => ( C4::Context->config('template_cache_dir') ? 0 : 1 ), xml_config_warnings => \@xml_config_warnings, warnStatisticsFieldsError => $warnStatisticsFieldsError, ); diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt index ddba5fd..e4d8dbd 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt @@ -138,7 +138,7 @@
[% IF warnPrefBiblioAddsAuthorities || warnPrefEasyAnalyticalRecords || warnPrefAnonymousPatron || warnPrefAnonymousPatron_PatronDoesNotExist || - warnNoActiveCurrency || QueryParserError || warnIsRootUser || xml_config_warnings.size || AutoSelfCheckPatronDoesNotHaveSelfCheckPerm || AutoSelfCheckPatronHasTooManyPerm || warnStatisticsFieldsError %] + warnNoActiveCurrency || QueryParserError || warnIsRootUser || xml_config_warnings.size || AutoSelfCheckPatronDoesNotHaveSelfCheckPerm || AutoSelfCheckPatronHasTooManyPerm || warnStatisticsFieldsError || warnNoTemplateCaching %] [% IF (warnIsRootUser) %]

Warning regarding current user

You are logged in as the database administrative user. This is not recommended because some parts of Koha will not function as expected when using this account.

@@ -146,7 +146,7 @@ [% END %] [% IF warnPrefBiblioAddsAuthorities || warnPrefEasyAnalyticalRecords || warnPrefAnonymousPatron || warnPrefAnonymousPatron_PatronDoesNotExist || - warnNoActiveCurrency || QueryParserError || AutoSelfCheckPatronDoesNotHaveSelfCheckPerm || AutoSelfCheckPatronHasTooManyPerm || warnStatisticsFieldsError%] + warnNoActiveCurrency || QueryParserError || AutoSelfCheckPatronDoesNotHaveSelfCheckPerm || AutoSelfCheckPatronHasTooManyPerm || warnStatisticsFieldsError || warnNoTemplateCaching %]

Warnings regarding the system configuration

@@ -190,6 +190,12 @@ The patron used for the self checkout module at the OPAC has too many permissions. They should only have circulate => self_checkout. [% END %] + [% IF warnNoTemplateCaching %] + + [% END %]
Preferences and parameters
Warning + You are missing the <template_cache_dir> entry in your koha-conf.xml file. + That will bring a performance boost to enable it. +
[% END %] -- 2.1.4