From 4749f196d5c35a525b20153beab51fc369f112f2 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 28 Dec 2016 13:14:06 +0100 Subject: [PATCH] Bug 17820: use ->find instead of search->next Content-Type: text/plain; charset=utf-8 From C4::Auth: my $patron = Koha::Patrons->search({ userid => $userid })->next; This should be replaced with my $patron = Koha::Patrons->find({ userid => $userid }); userid is a unique key Caught with NYTProf: # spent 78.9ms making 1 call to Koha::Objects::next Test plan: Login at the intranet Reload the page => You must still be logged in Signed-off-by: Marcel de Rooy Tested by enabling TrackLastPatronActivity and logging in again. Verified lastseen column in borrowers. --- C4/Auth.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Auth.pm b/C4/Auth.pm index 6b7dc66..c3ad657 100644 --- a/C4/Auth.pm +++ b/C4/Auth.pm @@ -1185,7 +1185,7 @@ sub checkauth { if ( $userid ) { # track_login also depends on pref TrackLastPatronActivity - my $patron = Koha::Patrons->search({ userid => $userid })->next; + my $patron = Koha::Patrons->find({ userid => $userid }); $patron->track_login if $patron; } -- 2.1.4