View | Details | Raw Unified | Return to bug 16755
Collapse All | Expand All

(-)a/C4/SIP/ILS/Item.pm (-2 / +13 lines)
Lines 165-172 sub hold_patron_id { Link Here
165
165
166
}
166
}
167
sub hold_patron_name {
167
sub hold_patron_name {
168
    my $self = shift;
168
    my ( $self, $template ) = @_;
169
    my $borrowernumber = (@_ ? shift: $self->hold_patron_id()) or return;
169
    my $borrowernumber = $self->hold_patron_id() or return;
170
171
    if ($template) {
172
        my $tt = Template->new();
173
174
        my $patron = Koha::Patrons->find($borrowernumber);
175
176
        my $output;
177
        $tt->process( \$template, { patron => $patron }, \$output );
178
        return $output;
179
    }
180
170
    my $holder = GetMember(borrowernumber=>$borrowernumber);
181
    my $holder = GetMember(borrowernumber=>$borrowernumber);
171
    unless ($holder) {
182
    unless ($holder) {
172
        syslog("LOG_ERR", "While checking hold, GetMember failed for borrowernumber '$borrowernumber'");
183
        syslog("LOG_ERR", "While checking hold, GetMember failed for borrowernumber '$borrowernumber'");
(-)a/C4/SIP/Sip/MsgType.pm (-1 / +1 lines)
Lines 679-685 sub handle_checkin { Link Here
679
            $resp .= maybe_add( FID_CALL_NUMBER,          $item->call_number );
679
            $resp .= maybe_add( FID_CALL_NUMBER,          $item->call_number );
680
            $resp .= maybe_add( FID_DESTINATION_LOCATION, $item->destination_loc );
680
            $resp .= maybe_add( FID_DESTINATION_LOCATION, $item->destination_loc );
681
            $resp .= maybe_add( FID_HOLD_PATRON_ID,       $item->hold_patron_bcode );
681
            $resp .= maybe_add( FID_HOLD_PATRON_ID,       $item->hold_patron_bcode );
682
            $resp .= maybe_add( FID_HOLD_PATRON_NAME,     $item->hold_patron_name );
682
            $resp .= maybe_add( FID_HOLD_PATRON_NAME,     $item->hold_patron_name( $server->{account}->{da_field_template} ) );
683
            if ( $status->hold and $status->hold->{branchcode} ne $item->destination_loc ) {
683
            if ( $status->hold and $status->hold->{branchcode} ne $item->destination_loc ) {
684
                warn 'SIP hold mismatch: $status->hold->{branchcode}=' . $status->hold->{branchcode} . '; $item->destination_loc=' . $item->destination_loc;
684
                warn 'SIP hold mismatch: $status->hold->{branchcode}=' . $status->hold->{branchcode} . '; $item->destination_loc=' . $item->destination_loc;
685
685
(-)a/etc/SIPconfig.xml (-1 / +1 lines)
Lines 51-56 Link Here
51
      <login id="lpl-sc-beacock" password="xyzzy"
51
      <login id="lpl-sc-beacock" password="xyzzy"
52
             delimiter="|" error-detect="enabled" institution="LPL"
52
             delimiter="|" error-detect="enabled" institution="LPL"
53
             send_patron_home_library_in_af="1"
53
             send_patron_home_library_in_af="1"
54
             da_field_template="[% patron.surname %][% IF patron.firstname %], [% patron.firstname %][% END %]"
54
             av_field_template="[% accountline.description %] [% accountline.amountoutstanding | format('%.2f') %]" >
55
             av_field_template="[% accountline.description %] [% accountline.amountoutstanding | format('%.2f') %]" >
55
          <screen_msg_regex find="Greetings from Koha." replace="Welcome to your library!" />
56
          <screen_msg_regex find="Greetings from Koha." replace="Welcome to your library!" />
56
          <screen_msg_regex find="Invalid patron barcode." replace="Barcode not found, are you sure this is your library card?" />
57
          <screen_msg_regex find="Invalid patron barcode." replace="Barcode not found, are you sure this is your library card?" />
57
- 

Return to bug 16755