Bugzilla – Attachment 58610 Details for
Bug 15738
Summary page says item has no fines, but Fines tab says otherwise
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15738: Show rental fees on OPAC summary page
Bug-15738-Show-rental-fees-on-OPAC-summary-page.patch (text/plain), 2.99 KB, created by
Aleisha Amohia
on 2017-01-05 02:04:35 UTC
(
hide
)
Description:
Bug 15738: Show rental fees on OPAC summary page
Filename:
MIME Type:
Creator:
Aleisha Amohia
Created:
2017-01-05 02:04:35 UTC
Size:
2.99 KB
patch
obsolete
>From d56f3e6eafee466dbc21af843ae0bfda457fa94b Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleishaamohia@hotmail.com> >Date: Thu, 5 Jan 2017 02:01:57 +0000 >Subject: [PATCH] Bug 15738: Show rental fees on OPAC summary page > >This patch adds a few lines that check for a rental fee on an item. If >yes, it will show in brackets as a rental fee on the OPAC summary page. > >To test: >1) Have a borrower with an overdue item accruing fines, a lost item and >an item with a rental fee. Confirm the Fines column on the OPAC summary >page now shows you what you may expect to see for each item. > >Sponsored-by: Catalyst IT >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 4 +++- > opac/opac-user.pl | 4 ++++ > 2 files changed, 7 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >index ef24771..0639ec4 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >@@ -274,7 +274,9 @@ Using this account is not recommended because some parts of Koha will not functi > <td class="fines"> > <span class="tdlabel">Fines:</span> > [% IF ( ISSUE.charges ) %] >- Yes >+ Yes (Item overdue or lost) >+ [% ELSIF ( ISSUE.rentalfines ) %] >+ Yes (Rental fees) > [% ELSE %] > No > [% END %] >diff --git a/opac/opac-user.pl b/opac/opac-user.pl >index 04a94c0..1a2db76 100755 >--- a/opac/opac-user.pl >+++ b/opac/opac-user.pl >@@ -186,6 +186,7 @@ if ($issues){ > > my ( $total , $accts, $numaccts) = GetMemberAccountRecords( $borrowernumber ); > my $charges = 0; >+ my $rentalfines = 0; > foreach my $ac (@$accts) { > if ( $ac->{'itemnumber'} == $issue->{'itemnumber'} ) { > $charges += $ac->{'amountoutstanding'} >@@ -194,9 +195,12 @@ if ($issues){ > if $ac->{'accounttype'} eq 'FU'; > $charges += $ac->{'amountoutstanding'} > if $ac->{'accounttype'} eq 'L'; >+ $rentalfines += $ac->{'amountoutstanding'} >+ if $ac->{'accounttype'} eq 'Rent'; > } > } > $issue->{'charges'} = $charges; >+ $issue->{'rentalfines'} = $rentalfines; > my $marcrecord = GetMarcBiblio( $issue->{'biblionumber'} ); > $issue->{'subtitle'} = GetRecordValue('subtitle', $marcrecord, GetFrameworkCode($issue->{'biblionumber'})); > # check if item is renewable >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15738
:
47628
|
49658
|
58610
|
62732
|
62747