From 941d64beda4f2e20febd82f9216093ff519c4b67 Mon Sep 17 00:00:00 2001 From: Patricio Marrone Date: Wed, 11 Jan 2017 12:39:21 -0300 Subject: [PATCH] Bug 17817: (Follow up) Fix reordering subfields issues Authority controlled subfields have invisible divs which produced a strange behavior when reordering (multiple clicks were needed to push a subfield up over an authority controlled subfield) Signed-off-by: Tomas Cohen Arazi --- koha-tmpl/intranet-tmpl/prog/js/cataloging.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js index 11974050c2..38edd2b036 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js +++ b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js @@ -423,8 +423,8 @@ function upSubfield(index) { } var tag = line.parentNode; // get the dad of this line. (should be "
") - // getting all subfields for this tag - var subfields = tag.querySelectorAll("div.subfield_line"); + // getting all visible subfields for this tag + var subfields = tag.querySelectorAll("div.subfield_line:not( [style*='display:none;'] )"); var subfieldsLength = subfields.length; if(subfieldsLength<=1) return; // nothing to do if there is just one subfield. -- 2.11.0