From c0011cf75f0e79ac6eb95705efe6c914546e3a29 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 13 Jan 2017 11:21:54 +0100 Subject: [PATCH] Bug 17196: [QA Follow-up] Adjust some text on marcxml Content-Type: text/plain; charset=utf-8 No code changes here, just text. Signed-off-by: Marcel de Rooy --- C4/Biblio.pm | 2 +- C4/Items.pm | 4 ++-- C4/Record.pm | 6 +++--- Koha/BiblioUtils/Iterator.pm | 7 ++++--- 4 files changed, 10 insertions(+), 9 deletions(-) diff --git a/C4/Biblio.pm b/C4/Biblio.pm index 0670d7b..9e93e25 100644 --- a/C4/Biblio.pm +++ b/C4/Biblio.pm @@ -164,7 +164,7 @@ Biblio.pm contains functions for managing storage and editing of bibliographic d =back -In the 3.0 version of Koha, the authoritative record-level information is in biblioitems.marcxml +In the 3.0 version of Koha, the authoritative record-level information is in biblio_metadata.metadata Because the data isn't completely normalized there's a chance for information to get out of sync. The design choice to go with a un-normalized schema was driven by performance and stability concerns. However, if this occur, it can be considered as a bug : The API is (or should be) complete & the only entry point for all biblio/items managements. diff --git a/C4/Items.pm b/C4/Items.pm index b435fee..3330a1f 100644 --- a/C4/Items.pm +++ b/C4/Items.pm @@ -323,7 +323,7 @@ embedded item fields. This routine is suitable for batch jobs. This API assumes that the bib record has already been saved to the C and C tables. It does -not expect that C are populated, but it +not expect that C is populated, but it will do so via a call to ModBibiloMarc. The goal of this API is to have a similar effect to using AddBiblio @@ -2650,7 +2650,7 @@ sub _SearchItems_build_where_fragment { $column = $kohafield; } else { # MARC field is not linked to a DB field so we need to use - # ExtractValue on biblioitems.marcxml or + # ExtractValue on marcxml from biblio_metadata or # items.more_subfields_xml, depending on the MARC field. my $xpath; my $sqlfield; diff --git a/C4/Record.pm b/C4/Record.pm index d081ac7..abc0075 100644 --- a/C4/Record.pm +++ b/C4/Record.pm @@ -228,7 +228,7 @@ EXAMPLE my dcxml = marc2dcxml (undef, undef, 1, "oaidc"); Convert MARC or MARCXML to Dublin Core metadata (XSLT Transformation), -optionally can get an XML directly from database (biblioitems.marcxml) +optionally can get an XML directly from biblio_metadata without item information. This method take into consideration the syspref 'marcflavour' (UNIMARC, MARC21 and NORMARC). Return an XML file with the format defined in C<$format> @@ -237,7 +237,7 @@ C<$marc> - an ISO-2709 scalar or MARC::Record object C<$xml> - a MARCXML file -C<$biblionumber> - obtain the record directly from database (biblioitems.marcxml) +C<$biblionumber> - biblionumber for database access C<$format> - accept three type of DC formats (oaidc, srwdc, and rdfdc ) @@ -258,7 +258,7 @@ sub marc2dcxml { # no need to catch errors or warnings marc2marcxml do it instead $marcxml = C4::Record::marc2marcxml( $marc ); } elsif ( not defined $xml and defined $biblionumber ) { - # get MARCXML biblio directly from biblioitems.marcxml without item information + # get MARCXML biblio directly without item information $marcxml = C4::Biblio::GetXmlBiblio( $biblionumber ); } else { $marcxml = $xml; diff --git a/Koha/BiblioUtils/Iterator.pm b/Koha/BiblioUtils/Iterator.pm index 8b62c80..0e71966 100644 --- a/Koha/BiblioUtils/Iterator.pm +++ b/Koha/BiblioUtils/Iterator.pm @@ -25,9 +25,10 @@ Koha::BiblioUtils::Iterator - iterates over biblios provided by a DBIx::Class::R =head1 DESCRIPTION -This provides an iterator that gives the MARC::Record of each biblio that's -returned by a L that provides a C, and -C column from the biblioitems table. +This provides an iterator over a L that contains a +biblionumber column. +Returns a MARC::Record in scalar context. +Returns biblionumber and marc in list context. =head1 SYNOPSIS -- 2.1.4