Bugzilla – Attachment 59142 Details for
Bug 17886
Don't show option to add to existing list if there are no lists in staff
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17886 Don't show option to add to existing list if there are no
Bug-17886-Dont-show-option-to-add-to-existing-list.patch (text/plain), 4.52 KB, created by
Claire Gravely
on 2017-01-18 07:22:42 UTC
(
hide
)
Description:
Bug 17886 Don't show option to add to existing list if there are no
Filename:
MIME Type:
Creator:
Claire Gravely
Created:
2017-01-18 07:22:42 UTC
Size:
4.52 KB
patch
obsolete
>From d835fb47890a8f3bb3692a2f18790d31b5a532e4 Mon Sep 17 00:00:00 2001 >From: Caitlin Goodger <caitlingoodger.student@wegc.school.nz> >Date: Wed, 18 Jan 2017 03:23:02 +0000 >Subject: [PATCH] Bug 17886 Don't show option to add to existing list if there > are no > >lists > >Test Plan >1: Make sure that you don't have any lists and then add a Biblical >Record to a list >2: You should see that you can add it to an existing list even though >you don't have one. >3: Apply patch >4: Add a Biblical record and if you don't have a list then you shouldn't >see the add to existing list. >5: Create a list and then add a Bibical Record and you should see the >add to existing list > >Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> >--- > .../en/modules/virtualshelves/addbybiblionumber.tt | 61 ++++++++++++---------- > 1 file changed, 32 insertions(+), 29 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/addbybiblionumber.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/addbybiblionumber.tt >index 63974a9..a2615e6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/addbybiblionumber.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/addbybiblionumber.tt >@@ -37,36 +37,38 @@ > [% UNLESS ( shelfnumber ) %] > > [% UNLESS ( newshelf ) %] >+[% IF ( private_shelves.count) %] > <fieldset class="rows"> >- <legend>Select an existing list</legend> >- <ol> >- <li> >- <label>Choose list</label> >- <select name="shelfnumber" id="shelfnumber"> >- [% IF private_shelves.count %] >- <optgroup label="Private lists"> >- [% FOREACH private_shelf IN private_shelves %] >- <option value="[% private_shelf.shelfnumber %]">[% private_shelf.shelfname | html%]</option> >- [% END %] >- </optgroup> >- [% END %] >- [% IF private_shelves_shared_with_me.count %] >- <optgroup label="Private lists shared with me"> >- [% FOREACH private_shelf IN private_shelves_shared_with_me %] >- <option value="[% private_shelf.shelfnumber %]">[% private_shelf.shelfname | html%]</option> >- [% END %] >- </optgroup> >- [% END %] >- [% IF public_shelves.count %] >- <optgroup label="Public lists"> >- [% FOREACH public_shelf IN public_shelves %] >- <option value="[% public_shelf.shelfnumber %]">[% public_shelf.shelfname | html%]</option> >- [% END %] >- </optgroup> >- [% END %] >- </select> >- </li> >- </ol> >+ <legend>Select an existing list</legend> >+ <ol> >+ <li> >+ <label>Choose list</label> >+ <select name="shelfnumber" id="shelfnumber"> >+ [% IF private_shelves.count %] >+ <optgroup label="Private lists"> >+ [% FOREACH private_shelf IN private_shelves %] >+ <option value="[% private_shelf.shelfnumber %]">[% private_shelf.shelfname | html%]</option> >+ [% END %] >+ </optgroup> >+ [% END %] >+ [% IF private_shelves_shared_with_me.count %] >+ <optgroup label="Private lists shared with me"> >+ [% FOREACH private_shelf IN private_shelves_shared_with_me %] >+ <option value="[% private_shelf.shelfnumber %]">[% private_shelf.shelfname | html%]</option> >+ [% END %] >+ </optgroup> >+ [% END %] >+ [% IF public_shelves.count %] >+ <optgroup label="Public lists"> >+ [% FOREACH public_shelf IN public_shelves %] >+ <option value="[% public_shelf.shelfnumber %]">[% public_shelf.shelfname | html%]</option> >+ [% END %] >+ </optgroup> >+ [% END %] >+ </select> >+ </li> >+ </ol> >+ > [% FOREACH biblio IN biblios %]<input type="hidden" name="biblionumber" value="[% biblio.biblionumber %]" />[% END %] > [% UNLESS ( biblionumbers ) %] > <input type="hidden" name="biblionumber" value="[% biblionumber %]" /> >@@ -76,6 +78,7 @@ > </fieldset> > > <p>... or...</p> >+ [% END %] > [% END %] > > <fieldset class="rows"><legend>Add to a new list:</legend> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17886
:
59138
|
59142
|
59282
|
59381
|
61117
|
75640
|
76306
|
76428