Bugzilla – Attachment 59410 Details for
Bug 17968
Remove useless variable in C4::Overdues::parse_overdues_letter
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17968: Remove useless variable $item_format in C4::Overdues::parse_overdues_letter
Bug-17968-Remove-useless-variable-itemformat-in-C4.patch (text/plain), 1.41 KB, created by
Jonathan Druart
on 2017-01-23 13:25:30 UTC
(
hide
)
Description:
Bug 17968: Remove useless variable $item_format in C4::Overdues::parse_overdues_letter
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-01-23 13:25:30 UTC
Size:
1.41 KB
patch
obsolete
>From dc19ac3daec1dedaa3023fee4162ff89b61a9c86 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 19 Jan 2017 18:03:55 +0100 >Subject: [PATCH] Bug 17968: Remove useless variable $item_format in > C4::Overdues::parse_overdues_letter > >The variable $item_format is not used and should be removed from this >subroutine. > >Moreover it the letter parameter, but it is never sent to this >subroutine. letter_code is expected instead. > >Test plan: >No test plan, just read the code and `git grep ` >--- > C4/Overdues.pm | 6 ------ > 1 file changed, 6 deletions(-) > >diff --git a/C4/Overdues.pm b/C4/Overdues.pm >index 8300a1e..c26b5f0 100644 >--- a/C4/Overdues.pm >+++ b/C4/Overdues.pm >@@ -1009,14 +1009,8 @@ sub parse_overdues_letter { > > my @item_tables; > if ( my $i = $params->{'items'} ) { >- my $item_format = ''; > foreach my $item (@$i) { > my $fine = GetFine($item->{'itemnumber'}, $params->{'borrowernumber'}); >- if ( !$item_format and defined $params->{'letter'}->{'content'} ) { >- $params->{'letter'}->{'content'} =~ m/(<item>.*<\/item>)/; >- $item_format = $1; >- } >- > $item->{'fine'} = currency_format($currency_format, "$fine", FMT_SYMBOL); > # if active currency isn't correct ISO code fallback to sprintf > $item->{'fine'} = sprintf('%.2f', $fine) unless $item->{'fine'}; >-- >2.9.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17968
:
59410
|
59484
|
59602