Bugzilla – Attachment 59534 Details for
Bug 17880
C4::Installer::PerlModules lexicographical comparison is incorrect
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17880: Fix copy/paste error
Bug-17880-Fix-copypaste-error.patch (text/plain), 1.84 KB, created by
David Cook
on 2017-01-24 23:06:51 UTC
(
hide
)
Description:
Bug 17880: Fix copy/paste error
Filename:
MIME Type:
Creator:
David Cook
Created:
2017-01-24 23:06:51 UTC
Size:
1.84 KB
patch
obsolete
>From 588cac7cac2aefc7b7145bcd44d97ae5f97eb30e Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Wed, 25 Jan 2017 09:58:40 +1100 >Subject: [PATCH] Bug 17880: Fix copy/paste error > >It looks like I made a copy/paste error in a previous patch. > >While the fix was working when you pass the param "module" to >version_info, it wasn't populating the version correctly >for the "all" param, which causes koha_perl_deps.pl to >think all OK modules actually need an upgrade. > >TEST PLAN > >0) Be on a system where you know your Koha Perl dependencies are >mostly up-to-date > >1) Run ./koha_perl_deps.pl -a -c >2) Note that most modules say they need an upgrade even when >the installed version is the same as the minimum version > >3) Apply patch > >4) Run ./koha_perl_deps.pl -a -c >5) Note that most moduls say they're OK, especially when the >installed version is the same or greater than the minimum version > >https://bugs.koha-community.org/show_bug.cgi?id=17880 >--- > C4/Installer/PerlModules.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Installer/PerlModules.pm b/C4/Installer/PerlModules.pm >index 9d8d1c8..2a64826 100644 >--- a/C4/Installer/PerlModules.pm >+++ b/C4/Installer/PerlModules.pm >@@ -84,7 +84,7 @@ sub version_info { > for (sort keys(%{$PERL_DEPS})) { > my $pkg = $_; # $_ holds the string > eval "require $pkg"; >- my $pkg_version = $params{'module'} && $params{'module'}->can("VERSION") ? $params{'module'}->VERSION : 0; >+ my $pkg_version = $pkg && $pkg->can("VERSION") ? $pkg->VERSION : 0; > my $min_version = $PERL_DEPS->{$_}->{'min_ver'} // 0; > if ($@) { > push (@{$self->{'missing_pm'}}, {$_ => {cur_ver => 0, min_ver => $PERL_DEPS->{$_}->{'min_ver'}, required => $PERL_DEPS->{$_}->{'required'}, usage => $PERL_DEPS->{$_}->{'usage'}}}); >-- >2.10.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17880
:
58857
|
58858
|
58998
|
58999
|
59074
|
59075
|
59533
|
59534