From f51a12f412e4ff9b1a56deaab168db565f8ecdce Mon Sep 17 00:00:00 2001 From: Mirko Tietgen Date: Mon, 30 Jan 2017 15:59:59 +0100 Subject: [PATCH] Bug 18015 - On shelf holds allowed > "If all unavailable" ignores notforloan If in the circ rules matrix you set "On shelf holds allowed" to "If all unavailable", items with status "Not for loan" are considered available and break the functionality. Test plan: - Set "On shelf holds allowed" to "If all unavailable" for your patron and item category (or everyone and everything) - Have two items for a record. Check out one - Set 7 - Not for loan: "Not For Loan" for the second item - Try to place a hold. Does not work. - Apply the patch - Try to place a hold. Should work now. Signed-off-by: Claire Gravely --- C4/Reserves.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Reserves.pm b/C4/Reserves.pm index 3f124a6..c078af1 100644 --- a/C4/Reserves.pm +++ b/C4/Reserves.pm @@ -1514,7 +1514,7 @@ sub IsAvailableForItemLevelRequest { foreach my $i (@items) { $any_available = 1 unless $i->itemlost - || $i->{notforloan} > 0 + || $i->notforloan > 0 || $i->withdrawn || $i->onloan || IsItemOnHoldAndFound( $i->id ) -- 2.1.4