Bugzilla – Attachment 59822 Details for
Bug 18036
Improve test coverage for themelanguage
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18036: Full complement of testing
Bug-18036-Full-complement-of-testing.patch (text/plain), 2.57 KB, created by
Mark Tompsett
on 2017-02-02 19:16:29 UTC
(
hide
)
Description:
Bug 18036: Full complement of testing
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2017-02-02 19:16:29 UTC
Size:
2.57 KB
patch
obsolete
>From 8ff64910595811ed2c161dc713d73e450e78d2dd Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Thu, 2 Feb 2017 14:15:13 -0500 >Subject: [PATCH] Bug 18036: Full complement of testing > >Added theme, lang, and availablethemes tests for all 4 cases. >--- > t/db_dependent/Templates.t | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Templates.t b/t/db_dependent/Templates.t >index bd1c45fc..3a2a9bc 100755 >--- a/t/db_dependent/Templates.t >+++ b/t/db_dependent/Templates.t >@@ -49,7 +49,7 @@ my @tables = qw( biblio biblioitems borrowers items statistics subscription ); > cmp_deeply( \@keys, \@tables, 'GetColumnDefs returns the expected tables'); > > subtest 'Testing themelanguage for unique themes (BZ 17982)' => sub { >- plan tests => 5; >+ plan tests => 12; > my $testing_language; > my $module_language = Test::MockModule->new('C4::Languages'); > >@@ -67,23 +67,30 @@ subtest 'Testing themelanguage for unique themes (BZ 17982)' => sub { > # trigger first case. > $testing_language = 'en'; > my ($theme, $lang, $availablethemes) = C4::Templates::themelanguage( $htdocs, 'about.tt', $section, $cgi); >+ is($theme,'prog',"Expected theme: set en - $theme"); > is($lang,'en','Expected language: set en'); >- cmp_deeply( $availablethemes, [ 'prog' ], 'We only expect one prog here' ); >+ cmp_deeply( $availablethemes, [ 'prog' ], 'We only expect one prog: set en' ); > > # trigger second case. > $testing_language = q{}; > ($theme, $lang, $availablethemes) = C4::Templates::themelanguage($htdocs, 'about.tt', $section, $cgi); >+ is($theme,'prog',"Expected theme: default en - $theme"); > is($lang,'en','Expected language: default en'); >+ cmp_deeply( $availablethemes, [ 'prog' ], 'We only expect one prog: default en' ); > > # trigger third case. > my $template = $htdocs . '/prog/en/modules/about.tt'; > ($theme, $lang, $availablethemes) = C4::Templates::themelanguage($htdocs, $template, $section, $cgi); >+ is($theme,'prog',"Expected defined theme: unset - $theme"); > is($lang,q{},'Expected language: unset'); >+ cmp_deeply( $availablethemes, [ 'prog' ], 'We only expect one prog: unset' ); > > # trigger bad case. > $template = $htdocs . '/prog/en/kaboom/about.tt'; > ($theme, $lang, $availablethemes) = C4::Templates::themelanguage($htdocs, $template, $section, $cgi); >+ is($theme,'1',"Expected strange theme: not coded for - $theme"); > is($lang,undef,'Expected language: not coded for'); >+ is( $availablethemes, undef, 'We only expect no prog: not coded for' ); > > return; > }; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18036
:
59767
|
59818
|
59819
|
59820
|
59821
|
59822
|
59823
|
59824
|
59825
|
59838
|
59839
|
59843
|
59844
|
59845
|
60351
|
60352
|
60353