Attachment 59850 Details for Bug 17736 – Bug 17736: [Follow-up] Resolve inherited AUTOLOAD for non-method errors

[patch] Bug 17736: [Follow-up] Resolve inherited AUTOLOAD for non-method errors

Bug-17736-Follow-up-Resolve-inherited-AUTOLOAD-for.patch (text/plain), 1.51 KB, created by Marcel de Rooy on 2017-02-03 08:17:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2017-02-03 08:17:06 UTC

Size: 1.51 KB

patch

obsolete

>From c44d7cc54fac9603db78bb73a0543a163cf18706 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 6 Jan 2017 11:21:10 +0100
>Subject: [PATCH] Bug 17736: [Follow-up] Resolve inherited AUTOLOAD for
> non-method errors
>Content-Type: text/plain; charset=utf-8
>
>Like:
>Use of inherited AUTOLOAD for non-method Koha::Biblio::GetMarcBiblio() is deprecated at /usr/share/koha/masterclone/Koha/Biblio.pm line 60.
>Use of inherited AUTOLOAD for non-method Koha::Biblio::GetRecordValue() is deprecated at /usr/share/koha/masterclone/Koha/Biblio.pm line 60.
>
>Resolved by not importing them but fully qualifying them.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> Koha/Biblio.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/Biblio.pm b/Koha/Biblio.pm
>index 7c86d5a..63b17a5 100644
>--- a/Koha/Biblio.pm
>+++ b/Koha/Biblio.pm
>@@ -21,7 +21,7 @@ use Modern::Perl;
> 
> use Carp;
> 
>-use C4::Biblio qw( GetRecordValue GetMarcBiblio GetFrameworkCode );
>+use C4::Biblio qw();
> 
> use Koha::Database;
> use Koha::DateUtils qw( dt_from_string );
>@@ -57,7 +57,7 @@ Keyword to MARC mapping for subtitle must be set for this method to return any p
> sub subtitles {
>     my ( $self ) = @_;
> 
>-    return map { $_->{subfield} } @{ GetRecordValue( 'subtitle', GetMarcBiblio( $self->id ), $self->frameworkcode ) };
>+    return map { $_->{subfield} } @{ C4::Biblio::GetRecordValue( 'subtitle', C4::Biblio::GetMarcBiblio( $self->id ), $self->frameworkcode ) };
> }
> 
> =head3 can_article_request
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 17736: 58015 | 58016 | 58017 | 58056 | 58057 | 58106 | 58107 | 58108 | 58628 | 58629 | 58630 | 58631 | 58632 | 58633 | 58634 | 58635 | 58636 | 58637 | 58638 | 58639 | 58640 | 58641 | 58642 | 58643 | 58644 | 58645 | 59846 | 59847 | 59848 | 59849 | 59850 | 59851 | 59852 | 59853 | 59854 | 59855 | 59859 | 59860 | 61406 | 61407 | 61408 | 61409 | 61410 | 61411 | 61412 | 61413 | 61414 | 61415 | 61416