Bugzilla – Attachment 59883 Details for
Bug 18014
AddAuthority should respect AUTO_INCREMENT
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18014: QA follow-up: Use ok() instead of is() for '>' comparison
Bug-18014-QA-follow-up-Use-ok-instead-of-is-for--c.patch (text/plain), 1.05 KB, created by
Julian Maurice
on 2017-02-03 12:57:29 UTC
(
hide
)
Description:
Bug 18014: QA follow-up: Use ok() instead of is() for '>' comparison
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2017-02-03 12:57:29 UTC
Size:
1.05 KB
patch
obsolete
>From e74ec1e8b0950ecf417538178aec0c1ad27833ed Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Fri, 3 Feb 2017 13:31:56 +0100 >Subject: [PATCH] Bug 18014: QA follow-up: Use ok() instead of is() for '>' > comparison > >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >--- > t/db_dependent/AuthoritiesMarc.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/db_dependent/AuthoritiesMarc.t b/t/db_dependent/AuthoritiesMarc.t >index d3ebc25f1a..57fcc883ef 100755 >--- a/t/db_dependent/AuthoritiesMarc.t >+++ b/t/db_dependent/AuthoritiesMarc.t >@@ -202,7 +202,7 @@ subtest 'AddAuthority should respect AUTO_INCREMENT (BZ 18104)' => sub { > isnt( $id1, $id2, 'Do not return the same id again' ); > t::lib::Mocks::mock_preference( 'marcflavour', 'UNIMARC' ); > my $id3 = AddAuthority( $record, undef, 'GEOGR_NAME' ); >- is( $id3 > 0, 1, 'Tested AddAuthority with UNIMARC' ); >+ ok( $id3 > 0, 'Tested AddAuthority with UNIMARC' ); > is( $record->field('001')->data, $id3, 'Check updated 001' ); > }; > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18014
:
59663
|
59664
|
59665
|
59667
|
59668
|
59669
|
59700
|
59701
|
59702
|
59869
|
59870
|
59871
|
59880
|
59881
|
59882
| 59883