Bugzilla – Attachment 59997 Details for
Bug 17461
Make plugins-home.pl complain about plugins that can not be loaded
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17461 - Warn about plugins that can't be loaded
Bug-17461---Warn-about-plugins-that-cant-be-loaded.patch (text/plain), 1.43 KB, created by
Liz Rea
on 2017-02-08 01:03:22 UTC
(
hide
)
Description:
Bug 17461 - Warn about plugins that can't be loaded
Filename:
MIME Type:
Creator:
Liz Rea
Created:
2017-02-08 01:03:22 UTC
Size:
1.43 KB
patch
obsolete
>From 4d03ec9f4088c484fdb7f681c2c1a5f8ff802487 Mon Sep 17 00:00:00 2001 >From: Magnus Enger <magnus@libriotech.no> >Date: Tue, 18 Oct 2016 09:47:19 +0000 >Subject: [PATCH] Bug 17461 - Warn about plugins that can't be loaded > >The logs should have some info if a module has been installed that can >not be loaded. > >To test: >- Make sure you have an up to date dev install >- Install v1.0 of the KitchenSink plugin from > https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases >- Make sure the plugin does not show up in the list of installed > plugins, and that the intranet-error.log has no info about it >- Apply the patch >- Reload plugins-home.pl >- Verify that there is now some interesting info in intranet-error.log > >Signed-off-by: Liz Rea <liz@catalyst.net.nz> >Works as advertised, generates useful diagnostic information in the form of a log entry to either intranet-error or plack-error.log. Relief, thanks Magnus! >--- > Koha/Plugins.pm | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/Koha/Plugins.pm b/Koha/Plugins.pm >index 6095f51..d2ec9c0 100644 >--- a/Koha/Plugins.pm >+++ b/Koha/Plugins.pm >@@ -86,6 +86,8 @@ sub GetPlugins { > and %$req_metadata > and any { !$plugin_metadata->{$_} || $plugin_metadata->{$_} ne $req_metadata->{$_} } keys %$req_metadata; > push @plugins, $plugin; >+ } else { >+ warn $Module::Load::Conditional::ERROR; > } > } > return @plugins; >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17461
:
56620
|
59997
|
60034