Bugzilla – Attachment 60068 Details for
Bug 11450
Hold Request Confirm Deletion
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11450: Hold Request Confirm Deletion
Bug-11450-Hold-Request-Confirm-Deletion.patch (text/plain), 2.19 KB, created by
Jonathan Druart
on 2017-02-09 12:44:31 UTC
(
hide
)
Description:
Bug 11450: Hold Request Confirm Deletion
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-02-09 12:44:31 UTC
Size:
2.19 KB
patch
obsolete
>From a3e5f49ae87e5d817368a837b3139d9fe2cba448 Mon Sep 17 00:00:00 2001 >From: Luke Honiss <luke.honiss@gmail.com> >Date: Thu, 19 Jan 2017 02:55:31 +0000 >Subject: [PATCH] Bug 11450: Hold Request Confirm Deletion > >==TEST PLAN== >1) Go to an item with a hold and click on the holds tab on the >left >2) Click the red 'X' >3) The hold will be deleted immediately >4) Apply patch >5) Return to an item with a hold and click the 'X' >6) There will now be a confirmation dialog >7) Click cancel and the dialog will disappear and the hold will not be >deleted >8) Click OK and the hold will be deleted > >Restored indentations - Mark Tompsett > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> >Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index 12b4e1b..6140472 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -168,6 +168,11 @@ function checkMultiHold() { > $("#" + fieldID).val(""); > }); > >+ // Confirm cancelation of hold >+ $(".cancel-hold").on("click",function(e) { >+ return confirmDelete(MSG_CONFIRM_DELETE_HOLD); >+ }); >+ > > [% UNLESS ( borrowernumber || borrowers || noitems ) %] > [% IF ( CircAutocompl ) %] >@@ -855,7 +860,7 @@ function checkMultiHold() { > [% END %] > > <td> >- <a title="Cancel hold" href="request.pl?action=cancel&borrowernumber=[% reserveloo.borrowernumber %]&biblionumber=[% reserveloo.biblionumber %]&reserve_id=[% reserveloo.reserve_id %]&date=[% reserveloo.date %]"> >+ <a class="cancel-hold" title="Cancel hold" href="request.pl?action=cancel&borrowernumber=[% reserveloo.borrowernumber %]&biblionumber=[% reserveloo.biblionumber %]&reserve_id=[% reserveloo.reserve_id %]&date=[% reserveloo.date %]"> > <img src="[% interface %]/[% theme %]/img/x.png" alt="Cancel" /> > </a> > </td> >-- >2.9.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11450
:
59203
|
59276
|
59505
|
59563
|
59967
|
59968
|
60036
| 60068 |
60122
|
60220