From 748cddad986a5dd2457306ae3d05554dc60711a9 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 15 Feb 2017 17:14:11 +0000 Subject: [PATCH] Bug 18025: Simplify logic and avoid 1 call to ValidateBorrowernumber Signed-off-by: Liz Rea This is fine with me. --- opac/opac-password-recovery.pl | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/opac/opac-password-recovery.pl b/opac/opac-password-recovery.pl index 2099caf..8c76015 100755 --- a/opac/opac-password-recovery.pl +++ b/opac/opac-password-recovery.pl @@ -90,16 +90,14 @@ if ( $query->param('sendEmail') || $query->param('resendEmail') ) { } # Check if a password reset already issued for this borrower AND we are not asking for a new email - elsif ( ValidateBorrowernumber( $borrower->borrowernumber ) - && !$query->param('resendEmail') ) - { - $hasError = 1; - $errAlreadyStartRecovery = 1; - } - elsif ( !ValidateBorrowernumber($borrower->borrowernumber) - && !$query->param('resendEmail') ) - { - DeleteExpiredPasswordRecovery($borrower->borrowernumber); + elsif ( not $query->param('resendEmail') ) { + if ( ValidateBorrowernumber( $borrower->borrowernumber ) ) { + $hasError = 1; + $errAlreadyStartRecovery = 1; + } + else { + DeleteExpiredPasswordRecovery( $borrower->borrowernumber ); + } } } else { # 0 matching borrower -- 2.1.4