From a080f0e6d74ab11ab7c41513250e320ba5cc344a Mon Sep 17 00:00:00 2001 From: Mark Tompsett Date: Thu, 2 Feb 2017 12:16:01 -0500 Subject: [PATCH] Bug 18036: Perlcritic improve t/db_dependent/Templates.t TEST PLAN --------- 1) apply 17982 2) perlcritic -3 t/db_dependent/Templates.t -- messages 3) apply this patch 4) perlcritic -3 t/db_dependent/Templates.t -- OK 5) run koha qa test tools Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart --- t/db_dependent/Templates.t | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/t/db_dependent/Templates.t b/t/db_dependent/Templates.t index 5c3b7c8..24bfd5d 100755 --- a/t/db_dependent/Templates.t +++ b/t/db_dependent/Templates.t @@ -43,10 +43,10 @@ my $columns = C4::Templates::GetColumnDefs( $query ); is( ref( $columns ) eq 'HASH', 1, 'GetColumnDefs returns a hashref' ); # get the tables names, sorted -my @keys = sort keys %$columns; -is( scalar @keys, 6, "GetColumnDefs correctly returns the 5 tables defined in columns.def" ); -my @tables = ( 'biblio', 'biblioitems', 'borrowers', 'items', 'statistics', 'subscription'); -cmp_deeply( \@keys, \@tables, "GetColumnDefs returns the expected tables"); +my @keys = sort keys %{$columns}; +is( scalar @keys, 6, 'GetColumnDefs correctly returns the 5 tables defined in columns.def' ); +my @tables = qw( biblio biblioitems borrowers items statistics subscription ); +cmp_deeply( \@keys, \@tables, 'GetColumnDefs returns the expected tables'); subtest 'Testing themelanguage for unique themes (BZ 17982)' => sub { plan tests => 1; -- 2.1.4