From 765c80b0b7fd27342557eb2418dc186d908b87f6 Mon Sep 17 00:00:00 2001 From: Mark Tompsett Date: Sat, 18 Feb 2017 23:06:16 -0500 Subject: [PATCH] Bug 18111: Swap framework_name and frameworkcode With the frameworkcode changed to an empty string, which really is closer to the physical reality, some javascript somewhere breaks. This means the spinner does not appear when you confirm that you wish to import it. TEST PLAN ---------- 1) apply first patch 2) export default framework, doesn't matter format 3) import default framework using that file. 4) answer yes or whatever it is. -- spinner does not appear. 5) apply this patch 6) import default framework use the same file. 7) answer yes or whatever it is. -- spinner does appear. 8) decide if you wish to find and fix the javascript conditions. if yes -- do so, and then obsolete this once you have. if not -- sign this off after running koha qa test tools --- admin/import_export_framework.pl | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/admin/import_export_framework.pl b/admin/import_export_framework.pl index 60dcf7f..b2d090d 100755 --- a/admin/import_export_framework.pl +++ b/admin/import_export_framework.pl @@ -46,8 +46,8 @@ unless ($authenticated) { exit 0; } -my $frameworkcode = $input->param('frameworkcode') || ''; -my $framework_name = $frameworkcode || 'default'; +my $framework_name = $input->param('frameworkcode') || 'default'; +my $frameworkcode = ($framework_name eq 'default') ? q{} : $framework_name; my $action = $input->param('action') || 'export'; ## Exporting diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt index 20efbc1..4edc861 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt @@ -189,7 +189,7 @@