Bugzilla – Attachment 60557 Details for
Bug 18070
Support clean removal of authority records
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18070: Deleting an authority should update the linked biblio records
Bug-18070-Deleting-an-authority-should-update-the-.patch (text/plain), 2.27 KB, created by
Julian Maurice
on 2017-02-22 14:46:13 UTC
(
hide
)
Description:
Bug 18070: Deleting an authority should update the linked biblio records
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2017-02-22 14:46:13 UTC
Size:
2.27 KB
patch
obsolete
>From b3973937b16aebb3c7f7c394143f0ff68180bd34 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Tue, 31 Jan 2017 11:46:21 +0100 >Subject: [PATCH] Bug 18070: Deleting an authority should update the linked > biblio records > >Adding a test where we delete an authority and prove that the linked >biblio still contains a reference to it. > >Note: Currently, you can only delete a used authority from Tools, >batch record deletion. If you do, the biblio records will still >contain references to the deleted authority. > >Test plan: >[1] Run t/db_dependent/Authorities/Merge.t > Last test should fail: not ok 1 - Field 609 should be gone too > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >--- > t/db_dependent/Authorities/Merge.t | 22 +++++++++++++++++++++- > 1 file changed, 21 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Authorities/Merge.t b/t/db_dependent/Authorities/Merge.t >index 726bad629d..32c19035ae 100755 >--- a/t/db_dependent/Authorities/Merge.t >+++ b/t/db_dependent/Authorities/Merge.t >@@ -4,7 +4,7 @@ > > use Modern::Perl; > >-use Test::More tests => 4; >+use Test::More tests => 5; > > use Getopt::Long; > use MARC::Record; >@@ -216,6 +216,26 @@ subtest 'Test merge A1 to B1 (changing authtype)' => sub { > 'Check 612x' ); > }; > >+subtest 'Merging authorities should handle deletes (BZ 18070)' => sub { >+ plan tests => 1; >+ >+ # Add authority and linked biblio, delete authority >+ my $auth1 = MARC::Record->new; >+ $auth1->append_fields( MARC::Field->new( '109', '', '', 'a' => 'DEL')); >+ my $authid1 = AddAuthority( $auth1, undef, $authtype1 ); >+ my $bib1 = MARC::Record->new; >+ $bib1->append_fields( >+ MARC::Field->new( '245', '', '', a => 'test DEL' ), >+ MARC::Field->new( '609', '', '', a => 'DEL', 9 => "$authid1" ), >+ ); >+ my ( $biblionumber ) = C4::Biblio::AddBiblio( $bib1, '' ); >+ DelAuthority( $authid1 ); >+ >+ # See what happened >+ my $marc1 = C4::Biblio::GetMarcBiblio( $biblionumber ); >+ is( $marc1->field('609'), undef, 'Field 609 should be gone too' ); >+}; >+ > sub set_mocks { > # Mock ZOOM objects: They do nothing actually > # Get new_record_from_zebra to return the records >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18070
:
59972
|
59973
|
59977
|
59978
|
60251
|
60252
|
60253
|
60254
|
60392
|
60393
|
60394
|
60395
| 60557 |
60558
|
60559
|
60560