From 951922c7fd1ac3c9dfa7980003ae04e85fbd36ca Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Mon, 27 Feb 2017 13:21:18 +0100 Subject: [PATCH] Bug 16966: [QA Follow-up] Check count, not size in template Content-Type: text/plain; charset=utf-8 The method size is not covered by tests at koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt line 163. The method size is not covered by tests at koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt line 183. Script cleanborrowers passes patrons_to_delete and patrons_to_anonymize to the template. One is an array ref where we should use 'size', the other is a Koha::Patrons object where we should use 'count'. If we don't, we will not anonymize a lot of records ;) Signed-off-by: Marcel de Rooy --- koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt index e5bf24d..7da2ff7 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt @@ -160,7 +160,7 @@ Warnings
@@ -177,9 +177,9 @@ [% END %] - [% IF patrons_to_anonymize.size %] - Checkout history for [% patrons_to_anonymize.size %] patrons will be anonymized - + [% IF patrons_to_anonymize.count %] + Checkout history for [% patrons_to_anonymize.count %] patrons will be anonymized + [% END %] -- 2.1.4