Bugzilla – Attachment 60821 Details for
Bug 18214
Cannot edit list permissions of a private list
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18214: Cannot edit list permissions of a private list
Bug-18214-Cannot-edit-list-permissions-of-a-privat.patch (text/plain), 2.24 KB, created by
Marcel de Rooy
on 2017-03-06 08:52:16 UTC
(
hide
)
Description:
Bug 18214: Cannot edit list permissions of a private list
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-03-06 08:52:16 UTC
Size:
2.24 KB
patch
obsolete
>From 90709e1ed4fdab44502dec269b9cc18c721f1e45 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 6 Mar 2017 09:44:48 +0100 >Subject: [PATCH] Bug 18214: Cannot edit list permissions of a private list >Content-Type: text/plain; charset=utf-8 > >If you have disabled the pref OpacAllowPublicListCreation, your users are >not able to edit the list permissions for private/shared lists. >For a private list they may only be theoretically relevant, but for a shared >list they are relevant. >Since we do not always know the history of a list (has it been public or >shared, does it contains entries from other users) and therefore permissions >are even relevant for a currently private list, we should just allow editing >these permissions. > >Test plan: >[1] Do not yet apply this patch. >[2] Disable OpacAllowPublicListCreation. >[3] Create a private list in OPAC. Edit the list. Verify that you do not > see the permission combo boxes. >[4] Apply this patch. Edit the list again. Do they appear now? > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >index 0e20fcf..a7721a6 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >@@ -601,8 +601,8 @@ > <span class="hint alert alert-info">The library has disabled the ability for patrons to create new public lists. If you make your list private, you will not be able to make it public again.</span> > [% END %] > </li> >- [% INCLUDE list_permissions %] > [% END %] >+ [% INCLUDE list_permissions %] > </ol> > [% UNLESS Koha.Preference('OpacAllowPublicListCreation') OR category == PUBLIC %] > <input type="hidden" name="category" value="[% PRIVATE %]" /> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18214
:
60821
|
60822
|
64504