@@ -, +, @@ old_issues.issue_id - We can no longer assume that accountlines.issue_id==old_issues.id (I - Code in Koha::REST::V1::_object_ownership_by_checkout_id is wrong --- C4/Circulation.pm | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) --- a/C4/Circulation.pm +++ a/C4/Circulation.pm @@ -2164,9 +2164,13 @@ sub MarkIssueReturned { # FIXME transaction my $sth_upd = $dbh->prepare($query); $sth_upd->execute(@bind); - my $sth_copy = $dbh->prepare('INSERT INTO old_issues SELECT * FROM issues - WHERE borrowernumber = ? - AND itemnumber = ?'); + my $sth_copy = $dbh->prepare(q| + INSERT INTO old_issues( issue_id, borrowernumber, itemnumber, date_due, branchcode, returndate, lastreneweddate, `return`, renewals, auto_renew, timestamp, issuedate, onsite_checkout ) + SELECT issue_id, borrowernumber, itemnumber, date_due, branchcode, returndate, lastreneweddate, `return`, renewals, auto_renew, timestamp, issuedate, onsite_checkout + FROM issues + WHERE borrowernumber = ? + AND itemnumber = ? + |); $sth_copy->execute($borrowernumber, $itemnumber); # anonymise patron checkout immediately if $privacy set to 2 and AnonymousPatron is set to a valid borrowernumber if ( $privacy == 2) { --