From 9ac5db9cd9964966979d6dcfba6207bffbc532d8 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 9 Mar 2017 16:41:31 -0300 Subject: [PATCH] Bug 18242: [SOLUTION 2]Add tests Signed-off-by: Chris Cormack --- t/db_dependent/Circulation/Returns.t | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/t/db_dependent/Circulation/Returns.t b/t/db_dependent/Circulation/Returns.t index f13dfd2305..de7bf64d1e 100644 --- a/t/db_dependent/Circulation/Returns.t +++ b/t/db_dependent/Circulation/Returns.t @@ -17,7 +17,7 @@ use Modern::Perl; -use Test::More tests => 3; +use Test::More tests => 4; use Test::MockModule; use Test::Warn; @@ -262,4 +262,30 @@ subtest "AddReturn logging on statistics table (item-level_itypes=0)" => sub { "biblio-level itype recorded on statistics for return"); }; +subtest 'Handle ids duplication' => sub { + plan tests => 1; + + my $biblio = $builder->build( { source => 'Biblio' } ); + my $item = $builder->build( + { + source => 'Item', + value => { + biblionumber => $biblio->{biblionumber}, + notforloan => 0, + itemlost => 0, + withdrawn => 0, + + } + } + ); + my $patron = $builder->build({source => 'Borrower'}); + + my $checkout = AddIssue( $patron, $item->{barcode} ); + $builder->build({ source => 'OldIssue', value => { issue_id => $checkout->issue_id } }); + + my @a = AddReturn( $item->{barcode} ); + my $old_checkout = Koha::Old::Checkouts->find( $checkout->issue_id ); + isnt( $old_checkout->itemnumber, $item->{itemnumber}, 'If an item is checked-in, it should be moved to old_issues even if the issue_id already existed in the table' ); +}; + 1; -- 2.11.0