Bugzilla – Attachment 61117 Details for
Bug 17886
Don't show option to add to existing list if there are no lists in staff
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17886: Forgot to count the lists shared to patron
Bug-17886-Forgot-to-count-the-lists-shared-to-patr.patch (text/plain), 1.96 KB, created by
Marc Véron
on 2017-03-15 18:37:11 UTC
(
hide
)
Description:
Bug 17886: Forgot to count the lists shared to patron
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2017-03-15 18:37:11 UTC
Size:
1.96 KB
patch
obsolete
>From 4092e7f638c6e69a1731ac03d864e535348a978a Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Fri, 20 Jan 2017 16:14:25 +0000 >Subject: [PATCH] Bug 17886: Forgot to count the lists shared to patron >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >The private_shelves_shared_with_me structure is defined, but >has 0 entries. The missing .count is the issue. > >TEST PLAN >--------- >1) Make sure no lists exist at all. >2) Make there is at least one findable biblio record entered >3) Find that biblio record in the OPAC >4) Click 'Save to your lists' >-- Notice that the whole save to list section is there. >5) apply this patch >6) Click 'Cancel' >7) Click 'Save to your lists' >-- Notice you can only add now, which makes sense. >8) run koha qa test tools. > >Followed test plan, works as expected. >Signed-off-by: Marc Véron <veron@veron.ch> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-addbybiblionumber.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-addbybiblionumber.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-addbybiblionumber.tt >index 164c750..aaa34e1 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-addbybiblionumber.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-addbybiblionumber.tt >@@ -23,7 +23,7 @@ > </li> > [% END %] > </ul> >- [% IF private_shelves.count or public_shelves.count or private_shelves_shared_with_me %] >+ [% IF private_shelves.count or public_shelves.count or private_shelves_shared_with_me.count %] > <form name="f1" action="/cgi-bin/koha/opac-addbybiblionumber.pl" method="post"> > <fieldset> > <legend>Select a list</legend> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17886
:
59138
|
59142
|
59282
|
59381
|
61117
|
75640
|
76306
|
76428