From 445279bc05cfd8474ca6d6fb7bce26d5e565413e Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Thu, 16 Mar 2017 11:28:29 -0400 Subject: [PATCH] Bug 18283 - Display improvements on report results - hide code and change wording This patch makes small display improvements to the report results page. -Add toggle link for SQL code -Change results count wording -Add 'Notes:' label report notes To test: 1 - Apply patch 2 - Run some reports 3 - Check that results page makes sense 4 - Hide and display code and ensure toggle works --- .../prog/en/modules/reports/guided_reports_start.tt | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt index ad53c08..ddda52c 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt @@ -172,6 +172,12 @@ $("#delColumn").on("click",function(){ }); [% END %] + $(".toggle_sql").click(function(){ + $("#sql_output").toggle(); + $("#toggle_sql_hid").toggle(); + $("#toggle_sql_vis").toggle(); + }); + $("#table_reports").delegate(".confirmdelete", 'click', function(){ $(this).parents('tr').attr("class","warn"); if(confirm(_("Are you sure you want to delete this saved report?"))){ @@ -822,9 +828,12 @@ canned reports and writing custom SQL reports.

[% IF ( execute ) %]

[% name %]

-[% IF ( notes ) %]

[% notes %]

[% END %] -[% IF ( unlimited_total ) %]

Total number of rows matching the (unlimited) query is [% unlimited_total %].

[% END %] -
[% sql |html %]
+[% IF ( notes ) %]

Notes: [% notes %]

[% END %] +[% IF ( unlimited_total ) %]

Total number of results [% unlimited_total %][% IF unlimited_total > limit %] ([% limit %] shown)[% END %].

[% END %] +Show sql code + + +
-- 2.1.4