From a8960f7f5940f88164952b0642a6d5ba35e135c5 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Thu, 16 Feb 2017 16:02:22 -0300 Subject: [PATCH] Bug 13757: (regression test) Attribute with value 0 should be stored Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart --- t/db_dependent/Koha/Patron/Modifications.t | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/t/db_dependent/Koha/Patron/Modifications.t b/t/db_dependent/Koha/Patron/Modifications.t index 8a3c94c..7c5593a 100755 --- a/t/db_dependent/Koha/Patron/Modifications.t +++ b/t/db_dependent/Koha/Patron/Modifications.t @@ -133,7 +133,7 @@ subtest 'store( extended_attributes ) tests' => sub { subtest 'approve tests' => sub { - plan tests => 18; + plan tests => 20; $schema->storage->txn_begin; @@ -148,7 +148,7 @@ subtest 'approve tests' => sub { ); my $verification_token = md5_hex( time().{}.rand().{}.$$ ); my $valid_json_text - = '[{"code":"CODE_1","value":"VALUE_1"},{"code":"CODE_2","value":"VALUE_2"}]'; + = '[{"code":"CODE_1","value":"VALUE_1"},{"code":"CODE_2","value":0}]'; my $patron_modification = Koha::Patron::Modification->new( { borrowernumber => $patron_hashref->{borrowernumber}, firstname => 'Kyle', @@ -172,6 +172,10 @@ subtest 'approve tests' => sub { 'CODE_1', 'Patron modification correctly saved attribute code' ); is( $patron_attributes[0][0]->{value}, 'VALUE_1', 'Patron modification correctly saved attribute value' ); + is( $patron_attributes[0][1]->{code}, + 'CODE_2', 'Patron modification correctly saved attribute code' ); + is( $patron_attributes[0][1]->{value}, + 0, 'Patron modification correctly saved attribute with value 0, not confused with delete' ); # Create a new Koha::Patron::Modification, skip extended_attributes to # bypass checks -- 2.9.3