Bugzilla – Attachment 61595 Details for
Bug 17964
TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17964: [QA Follow-up] Test descriptions, typo
Bug-17964-QA-Follow-up-Test-descriptions-typo.patch (text/plain), 2.81 KB, created by
Marcel de Rooy
on 2017-03-24 08:31:41 UTC
(
hide
)
Description:
Bug 17964: [QA Follow-up] Test descriptions, typo
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-03-24 08:31:41 UTC
Size:
2.81 KB
patch
obsolete
>From 94ab35aa63b3d10244a0da757cdc390f5ccc3e5f Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 24 Mar 2017 09:05:44 +0100 >Subject: [PATCH] Bug 17964: [QA Follow-up] Test descriptions, typo >Content-Type: text/plain; charset=utf-8 > >Typo: have been checkin => checked. >And five test descriptions ;) > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/Letters/TemplateToolkit.t | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > >diff --git a/t/db_dependent/Letters/TemplateToolkit.t b/t/db_dependent/Letters/TemplateToolkit.t >index 810961a..2a5a0f4 100644 >--- a/t/db_dependent/Letters/TemplateToolkit.t >+++ b/t/db_dependent/Letters/TemplateToolkit.t >@@ -337,7 +337,7 @@ Your library. > |; > my $tt_letter = process_letter( { template => $tt_template, %$params }); > >- is( $tt_letter->{content}, $letter->{content}, ); >+ is( $tt_letter->{content}, $letter->{content}, 'Verified letter content' ); > }; > > subtest 'AR_*' => sub { >@@ -417,7 +417,7 @@ Thank you for visiting <<branches.branchname>>. > |; > reset_template( { template => $checkout_template, code => $checkout_code, module => 'circulation' } ); > my $checkin_template = q[ >-The following items have been checkin out: >+The following items have been checked out: > ---- > <<biblio.title>> was due on <<old_issues.date_due | dateonly>> > ---- >@@ -447,7 +447,7 @@ Thank you for visiting [% branch.branchname %]. > |; > reset_template( { template => $checkout_template, code => $checkout_code, module => 'circulation' } ); > $checkin_template = q[ >-The following items have been checkin out: >+The following items have been checked out: > ---- > [% biblio.title %] was due on [% old_checkout.date_due | $KohaDates %] > ---- >@@ -465,10 +465,10 @@ Thank you for visiting [% branch.branchname %]. > AddReturn( $item2->{barcode} ); > my $second_checkin_tt_letter = Koha::Notice::Messages->search( {}, { order_by => { -desc => 'message_id' } } )->next; > >- is( $first_checkout_tt_letter->content, $first_checkout_letter->content, ); >- is( $second_checkout_tt_letter->content, $second_checkout_letter->content, ); >- is( $first_checkin_tt_letter->content, $first_checkin_letter->content, ); >- is( $second_checkin_tt_letter->content, $second_checkin_letter->content, ); >+ is( $first_checkout_tt_letter->content, $first_checkout_letter->content, 'Verify first checkout letter' ); >+ is( $second_checkout_tt_letter->content, $second_checkout_letter->content, 'Verify second checkout letter' ); >+ is( $first_checkin_tt_letter->content, $first_checkin_letter->content, 'Verify first checkin letter' ); >+ is( $second_checkin_tt_letter->content, $second_checkin_letter->content, 'Verify second checkin letter' ); > > }; > }; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17964
:
59436
|
59437
|
59438
|
59540
|
59541
|
59542
|
60403
|
60404
|
60405
|
61595
|
61627
|
62460
|
62461
|
62462
|
62463
|
62464